BUG: Fix debug and coverage arguments with dev.py #15968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgommers
reviewed
Apr 10, 2022
There was a problem hiding this comment.
Thanks @Smit-create. This looks correct, and at least the build works for me. Installing lcov now to test that part. Did you get a html report out with --lcov-html?
The rest of the if args.debug or args.gcov: block looks like it needs removing as well. https://mesonbuild.com/Builtin-options.html#core-options says that the default buildtype is debug, so this block can simply be removed.
There's also this part:
if args.debug and args.bench:
print("*** Benchmarks should not be run against debug version; "
"remove -g flag ***")
That's a bit harder to know what to do with. If the default build is debug, we should make it easier to run benchmarks in release modes. Let's leave that for a separate issue/PR.
|
I'm getting a lot of warnings, ending in: |
I also get the same warnings. Using |
|
Okay, how about this:
|
Smit-create
changed the title
rgommers
changed the title
Some of these warnings look like: |
|
@Smit-create |
|
Once that works, it would also be nice to document how to do a debug build in the "advanced Meson build topics" docs section. |
|
@Smit-create sorry I wasn't quite aware yet two hours ago, and mixed up two different things in my comment above. For debug builds, it would indeed be nice to document it as I suggested, and you do want the Python/NumPy debug builds for that as well. For code coverage with gcov there's more issues and it doesn't need a Python debug build, just SciPy itself built without optimizations (see gh-10215 for comments). |
rgommers
approved these changes
Apr 12, 2022
There was a problem hiding this comment.
After fixing the missing dash, this actually seems to work:
$ python dev.py --gcov -j4
$ cd build # note: this is needed in order for source files to be found
$ find . -name '*.gcno' -type f -exec gcov -pb {} +
...
File 'scipy/sparse/csgraph/_traversal.cpython-310-x86_64-linux-gnu.so.p/_traversal.c'
Lines executed:56.60% of 3666
Branches executed:59.37% of 2845
Taken at least once:30.44% of 2845
Calls executed:36.26% of 717
Creating 'scipy#sparse#csgraph#_traversal.cpython-310-x86_64-linux-gnu.so.p#_traversal.c.gcov'
File 'scipy/sparse/_csparsetools.cpython-310-x86_64-linux-gnu.so.p/_csparsetools.c'
Lines executed:38.32% of 13913
Branches executed:45.93% of 11394
Taken at least once:23.95% of 11394
Calls executed:34.53% of 3803
Creating 'scipy#sparse#_csparsetools.cpython-310-x86_64-linux-gnu.so.p#_csparsetools.c.gcov'
The --lcov-html part still has an issue with paths. Some careful checking should be able to fix that - it does work in runtests.py, the only difference is the out of place build with Meson. Can you look at that in a follow-up @Smit-create? That will close gh-15896.
dev.py
Outdated
| @@ -432,6 +432,8 @@ def setup_build(args, env): | |||
| return | |||
| if args.werror: | |||
| cmd += ["--werror"] | |||
| if args.gcov: | |||
| cmd += ['Db_coverage=true'] | |||
There was a problem hiding this comment.
@Smit-create it looks like you didn't actually test this, because it's missing a dash (it should be -Db_coverage=true to avoid seeing:
meson: error: unrecognized arguments: Db_coverage=true
Meson build setup failed! ({0} elapsed)
There was a problem hiding this comment.
Oops! sorry. I just missed that in some hurry.
Yeah, |
|
Yes that's just due to paths. Note that |
|
Yeah, I was trying to generate the report using |
|
You did not get any warning about not having |
|
If I understood correctly,
Traceback
|
|
@sayantikabanik it's working with GCC + gcov. I have no idea what to expect when you mix Clang with gcov, which you are doing here (the missing symbol is |
|
I was trying to generate the report using This works by printing out: What should I do to generate the HTML report after this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @rgommers