BUG: stats: fix misnamed _argcheck method of the erlang distribution. #198

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
@WarrenWeckesser
Member

WarrenWeckesser commented Apr 22, 2012

Closes #1647 (http://projects.scipy.org/scipy/ticket/1647).

Reviewers: be sure to read the comments in the trac ticket.

@pv

This comment has been minimized.

Show comment
Hide comment
@pv

pv Apr 25, 2012

Member

Seems correct to me.

Member

pv commented Apr 25, 2012

Seems correct to me.

@WarrenWeckesser

This comment has been minimized.

Show comment
Hide comment
@WarrenWeckesser

WarrenWeckesser Apr 25, 2012

Member

The code changes are pretty simple, but there is a discussion in the trac ticket about whether erlang should allow non-integer shape parameters. (This would make erlang an alias for gamma.) If you have an opinion on that, could you add a comment in the trac ticket?

Member

WarrenWeckesser commented Apr 25, 2012

The code changes are pretty simple, but there is a discussion in the trac ticket about whether erlang should allow non-integer shape parameters. (This would make erlang an alias for gamma.) If you have an opinion on that, could you add a comment in the trac ticket?

@josef-pkt

This comment has been minimized.

Show comment
Hide comment
@josef-pkt

josef-pkt Jun 3, 2012

Member

As discussed on the ticket and mailing list, I'm pretty much against this change. It breaks the pattern of continuous parameter spaces without sufficient benefits that I can see.

The only reason to make this change is if we also create a fit method that restricts to discrete parameter spaces.

Member

josef-pkt commented Jun 3, 2012

As discussed on the ticket and mailing list, I'm pretty much against this change. It breaks the pattern of continuous parameter spaces without sufficient benefits that I can see.

The only reason to make this change is if we also create a fit method that restricts to discrete parameter spaces.

@rgommers

This comment has been minimized.

Show comment
Hide comment
@rgommers

rgommers Jun 6, 2013

Member

Fixed by gh-2507.

Member

rgommers commented Jun 6, 2013

Fixed by gh-2507.

@rgommers rgommers closed this Jun 6, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment