BUG: integrate: fix complex_ode y attribute #220

Merged
merged 1 commit into from Jun 9, 2012

Conversation

Projects
None yet
2 participants
@pv
Owner

pv commented May 19, 2012

From ticket http://projects.scipy.org/scipy/ticket/1623

Thanks to borishim for the patch.

IMHO, it's probable that nobody is relying on the old behavior, as the contents of the y variable were misleadingly documented. Anyway, I'm thinking that just mentioning this in the release notes is enough for the transition... Thoughts?


scipy.integrate.complex_ode solves a complex valued problem by converting the problem to an equivalent real valued one. However, the member variable y of the class instance is a not a complex array but a float array filled with alternating real and imaginary parts. This behavior is not documented clearly. I changed the name of the member variable self.y to self._y and added a getter using property decorator. This patch should be backward compatible for existing real valued problems and more convenient for complex valued problems.

@rgommers

This comment has been minimized.

Show comment Hide comment
@rgommers

rgommers May 20, 2012

Owner

That explanation in the release notes is enough I think.

Owner

rgommers commented May 20, 2012

That explanation in the release notes is enough I think.

BUG: integrate: fix complex_ode y attribute
Thanks to borishim for the patch.

pv added a commit that referenced this pull request Jun 9, 2012

Merge pull request #220 from pv/ticket/1623
BUG: integrate: fix complex_ode y attribute

@pv pv merged commit 8bb894b into scipy:master Jun 9, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment