TST: sparse: mark dok matrix tests as knownfail with python 2.4. #237

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Owner

rgommers commented Jun 4, 2012

I propose to mark these as knownfail in master, because it has never been an issue and can be worked around if necessary.

See http://projects.scipy.org/scipy/ticket/1559

(commit cherry-picked from 5013ec0)

Member

jakevdp commented Jun 4, 2012

Looks good. Do we have any idea why this fails only in 2.4?

Owner

rgommers commented Jun 5, 2012

From the ticket:

dok_matrix.__radd__ (which has the todense() call) is called for Python >= 2.5, but not
for 2.4. I can't find anything related to this in the "what's new in python 2.5" doc. 
Owner

rgommers commented Jun 9, 2012

The issue seems to have been fixed by #229 (which regenerated SWIG wrappers), so closing.

@rgommers rgommers closed this Jun 9, 2012

Owner

rgommers commented Jul 21, 2012

This seems to not be fixed after all; Scott Sinclair reported these tests as failing on his system with Python 2.4. So committed this PR as 3ba682b.

Owner

rgommers commented Jul 21, 2012

And backported to 0.11.x in c01cf87.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment