Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
BUG: Trac ticket 1491: ndimage.label ignores output keyword #240
Thouis thanks for addressing this ticket!
With this pull ndimage.label is doing what the documentation describes, but unless I am mistaken a int32 array is still used for the labeling not the passed array. This is going to result in more memory usage than necessary. It seems to me that a better solution would be to have NI_Label in ni_measure.c write to the passed output array in a manner similar to NI_ZoomShift in ni_interpolation.c (there are probably other example but this is the one I am most familar with). This will oviously be a much more involved patch, but I though I should mention it.
Again, Thouis thanks your work, it is nice to have a solution to this problem.