New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add feature to read/write floating point WAV files to scipy.io.wavfile module. #2440

Merged
merged 2 commits into from May 3, 2013

Conversation

Projects
None yet
2 participants
@7islands
Contributor

7islands commented May 3, 2013

The enhancement adds a feature to read and write floating point WAV files to scipy.io.wavfile.read and scipy.io.wavfile.write functions where currently only integer types are supported.

ENH: Add feature to read/write floating point WAV files.
The enhancement adds a feature to read and write floating point WAV files to
`scipy.io.wavfile.read` and `scipy.io.wavfile.write` functions where currently
only integer types are supported.
@pv

This comment has been minimized.

Member

pv commented May 3, 2013

Thanks, this looks useful.

The wavfile.write routine should probably also reject data types that it doesn't understand.

@7islands

This comment has been minimized.

Contributor

7islands commented May 3, 2013

Thanks for the comment. Added a check to reject unsupported data types (e91bad1).

pv added a commit that referenced this pull request May 3, 2013

Merge pull request #2440 from 7islands/wavfile-floating-point
ENH: wavfile: read/write floating point WAV files

Also, refuse to write malformed wav files.

@pv pv merged commit e91bad1 into scipy:master May 3, 2013

@pv

This comment has been minimized.

Member

pv commented May 3, 2013

Thanks, merged in ccbdff8

@7islands

This comment has been minimized.

Contributor

7islands commented May 4, 2013

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment