BUG: Fix API types for minpack. #269

Merged
merged 1 commit into from Jul 23, 2012

Conversation

Projects
None yet
4 participants
Owner

stefanv commented Jul 17, 2012

Pull request for: http://projects.scipy.org/scipy/ticket/1700

Patch by Yaroslav Halchenko.

Fixed API type mismatches for minpack on s390.

Contributor

yarikoptic commented Jul 17, 2012

Disclaimer: I am really not sure if that was the optimal way to resolve the type mismatch here ;-)

Member

jakevdp commented Jul 18, 2012

Thanks for the patch. I think this looks like the right way to go: AFAIK, there won't be any problems with this sort of casting in C.

For what it's worth, tests all pass on my system (64 bit ubuntu), though they passed before as well.

Contributor

yarikoptic commented Jul 18, 2012

cool, thanks @jakevdp

among all architectures supported by Debian this issue was only present on s390x (triggered by unittests of pymvpa2):
https://buildd.debian.org/status/package.php?p=pymvpa2&suite=sid
so it is not really surprising that it was not detected before ;)

Owner

rgommers commented Jul 23, 2012

Looks good. I've tested this with Python 2.4 and 3.2 on OS X and 2.5 on Windows XP, no problems. Fine for backporting to 0.11.x too. We'll need a second RC there anyway due to the QZ issue.

rgommers added a commit that referenced this pull request Jul 23, 2012

Merge pull request #269 from stefanv/minpack_API_types
BUG: Fix API types for minpack.

@rgommers rgommers merged commit 0028e16 into scipy:master Jul 23, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment