New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP: remove deprecated umfpack wrapper. Closes gh-3002. #3178

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@rgommers
Copy link
Member

rgommers commented Dec 30, 2013

Executive summary:

  • this is due to license issues, UMFPACK changed from a BSD-compatible license
    to GPL a long time ago.
  • this solves install issues; SWIG was always an undocumented build-time
    dependency if UMFPACK was installed on a system.
  • scikits.umfpack was lost, but @rc is about to revive it.
DEP: remove deprecated umfpack wrapper. Closes gh-3002.
Executive summary:
- this is due to license issues, UMFPACK changed from a BSD-compatible license
  to GPL a long time ago.
- this solves install issues; SWIG was always an undocumented build-time
  dependency if UMFPACK was installed on a system.
- scikits.umfpack was lost, but @rc is about to revive it.
@rgommers

This comment has been minimized.

Copy link
Member

rgommers commented Dec 30, 2013

@rc do you see any problem in merging this already? No functionality is lost even before the scikit is available I think, only some performance.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 30, 2013

Coverage Status

Coverage remained the same when pulling f8396b3 on rgommers:remove-umfpack into 7eca39e on scipy:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 30, 2013

Coverage Status

Coverage remained the same when pulling f8396b3 on rgommers:remove-umfpack into 7eca39e on scipy:master.

@rc

This comment has been minimized.

Copy link
Contributor

rc commented Dec 30, 2013

+1 to merge it now.

@meawoppl

This comment has been minimized.

Copy link
Contributor

meawoppl commented Jan 4, 2014

+1 to merge. umfpack is really important to what I do, but does indeed belong in a scikit IMHO.

@rgommers

This comment has been minimized.

Copy link
Member

rgommers commented Jan 31, 2014

Time to merge this?

pv added a commit that referenced this pull request Feb 9, 2014

Merge pull request #3178 from rgommers/remove-umfpack
DEP: remove deprecated umfpack wrapper
@pv

This comment has been minimized.

Copy link
Member

pv commented Feb 9, 2014

Merged in 8cab889

@pv pv closed this Feb 9, 2014

@jseabold jseabold referenced this pull request Feb 13, 2014

Closed

Wrappers license? #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment