BUG: fix segfault in fftpack on OS X >=10.7 when compiling with llvm-gcc... #330

Merged
merged 1 commit into from Oct 30, 2012

Conversation

Projects
None yet
2 participants
Owner

rgommers commented Oct 3, 2012

....

See ticket 1737. Thanks to Alex Leach for help in debugging this issue.

Tested by Alex to confirm it fixes the segfault, works fine on Ubuntu 12.04 too. Ticket shouldn't be closed yet.

@rgommers rgommers BUG: fix segfault in fftpack on OS X >=10.7 when compiling with llvm-…
…gcc.

See #1737.  Thanks to Alex Leach for help in debugging this issue.
61fbbb6
Owner

rgommers commented Oct 3, 2012

Hmm, tabs vs. spaces issue. What do I do here, convert all tabs to 4 spaces?

Owner

rgommers commented Oct 3, 2012

In Trac ticket 1496 the same issue was encountered. Added a note there that this PR should fix it.

Owner

pv commented Oct 30, 2012

Seems like working around compiler bugs. But anyway, the new code is cleaner, so merging would be OK.

Owner

rgommers commented Oct 30, 2012

OK, thanks for having a look. Merging.

@rgommers rgommers added a commit that referenced this pull request Oct 30, 2012

@rgommers rgommers Merge pull request #330 from rgommers/ticket-1737-llvmgcc-fftpack
BUG: fix segfault in fftpack on OS X >=10.7 when compiling with llvm-gcc...
bb436fa

@rgommers rgommers merged commit bb436fa into scipy:master Oct 30, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment