ENH: sparse/dsolve: make the L and U factors of splu and spilu accessible #3375

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
3 participants
Owner

pv commented Feb 22, 2014

The L and U factors in sparse direct LU decomposition computed by SuperLU
are not currently accessible from Python. This PR makes them accessible.

The PR also renames the superlu object returned by splu() and spilu() to something
a bit saner, and links it to the documentation.

The module in principle could be rewritten in Cython, but that's a job for another day.

Goes on top of gh-3367 (new commits in this PR start from 1f49ccd)

Coverage Status

Coverage remained the same when pulling 357044e on pv:splu-lu into 1b34692 on scipy:master.

Owner

rgommers commented Feb 23, 2014

Has a few 0.15.0 version numbers in it. You want to wait with merging this?

Owner

pv commented Feb 23, 2014

Changed tags to 0.14.0. No need to wait if no comments.

Owner

rgommers commented Feb 23, 2014

Looks sensible to me. I don't use SuperLU though, so I'll ping the mailing list to see if someone wants to take a look. If not, let's merge it.

Would make sense to rebase this to get rid of the commits that are already in master.

Coverage Status

Coverage remained the same when pulling 256fb9e on pv:splu-lu into 1b34692 on scipy:master.

Owner

pv commented Feb 23, 2014

Rebased.

Owner

rgommers commented Feb 23, 2014

Sent message to list

Coverage Status

Coverage remained the same when pulling 6e2f5c6 on pv:splu-lu into 6404b88 on scipy:master.

Owner

rgommers commented Feb 26, 2014

No response from message to list. So let's merge this. Does need another rebase.

rgommers added this to the 0.14.0 milestone Feb 26, 2014

@rgommers rgommers added a commit that referenced this pull request Feb 27, 2014

@rgommers rgommers Merge branch 'pr/3375' into master.
Review at #3375
db04dff
Owner

rgommers commented Feb 27, 2014

Rebased and merged in db04dff.

rgommers closed this Feb 27, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment