Skip to content

BUG: SuperLU: fix missing declaration of dlamch #3388

Merged
merged 1 commit into from Feb 25, 2014

3 participants

@pv
SciPy member
pv commented Feb 25, 2014

SuperLU 4.3 called some functions returning floats without declaring
them. On i386@linux call convention, this fails to clear floating point
registers after call. As a result, NaN can appear in the next floating
point operation made.

Squashes a couple of the current test failures on i386.

@pv pv BUG: SuperLU: fix missing declaration of dlamch
SuperLU 4.3 called some functions returning floats without declaring
them. On i386@linux call convention, this fails to clear floating point
registers after call. As a result, NaN can appear in the next floating
point operation made.
4796e0d
@pv pv added the PR label Feb 25, 2014
@pv pv added this to the 0.14.0 milestone Feb 25, 2014
@coveralls

Coverage Status

Coverage remained the same when pulling 4796e0d on pv:superlu-bug into 77a7e48 on scipy:master.

@rgommers rgommers merged commit 1eb7182 into scipy:master Feb 25, 2014

1 check passed

Details default The Travis CI build passed
@rgommers
SciPy member

Fixes the failure, merging. Thanks @pv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.