BUG: SuperLU: fix missing declaration of dlamch #3388

Merged
merged 1 commit into from Feb 25, 2014

Conversation

Projects
None yet
3 participants
@pv
Member

pv commented Feb 25, 2014

SuperLU 4.3 called some functions returning floats without declaring
them. On i386@linux call convention, this fails to clear floating point
registers after call. As a result, NaN can appear in the next floating
point operation made.

Squashes a couple of the current test failures on i386.

BUG: SuperLU: fix missing declaration of dlamch
SuperLU 4.3 called some functions returning floats without declaring
them. On i386@linux call convention, this fails to clear floating point
registers after call. As a result, NaN can appear in the next floating
point operation made.

@pv pv added the PR label Feb 25, 2014

@pv pv added this to the 0.14.0 milestone Feb 25, 2014

@pv pv added defect labels Feb 25, 2014

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Feb 25, 2014

Coverage Status

Coverage remained the same when pulling 4796e0d on pv:superlu-bug into 77a7e48 on scipy:master.

Coverage Status

Coverage remained the same when pulling 4796e0d on pv:superlu-bug into 77a7e48 on scipy:master.

rgommers added a commit that referenced this pull request Feb 25, 2014

Merge pull request #3388 from pv/superlu-bug
BUG: SuperLU: fix missing declaration of dlamch

@rgommers rgommers merged commit 1eb7182 into scipy:master Feb 25, 2014

1 check passed

default The Travis CI build passed
Details
@rgommers

This comment has been minimized.

Show comment
Hide comment
@rgommers

rgommers Feb 25, 2014

Member

Fixes the failure, merging. Thanks @pv

Member

rgommers commented Feb 25, 2014

Fixes the failure, merging. Thanks @pv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment