WIP: Update to cython 0.17.1 #341

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
2 participants
Contributor

matthew-brett commented Oct 22, 2012

Testing on python 3.3 we get a test failure "ValueError: level must be >=0". This turned out to be due to some Cython generated C code for importing, fixed in Cython 0.17.

So, the main change is updating all the C files from pyx sources with Cython 0.17.

I believe this makes us incompatible with Python 2.4. If that's the case, I think we should drop 2.4 support in trunk, maybe offering bugfix support on a branch from 0.11?. I"m afraid I'm offline most of the time (in Cuba) so can't make that case on the list.

matthew-brett added some commits Oct 21, 2012

@matthew-brett matthew-brett BUG: remove inline statement rejected by cython
Cython 0.17.1 rejects inline in the function definition for cpdef
functions.
73fc7ae
@matthew-brett matthew-brett BUG: fix depenency on dict ordering in test
Python 3.3 discovered the dependency on dict ordering
1d4c9dc
@matthew-brett matthew-brett BUG: process pyx files with Cython 0.17.1
This fixes import errors in Python 3.3, because Cython < 0.17 generated
C code that results in the python C import function being passed a
``level` of '-1'. The value of -1 meant (before python 3.3) that the
import can be absolute or relative. In Python 3.3, a level of -1 raises
an error:

   ValueError: level must be >= 0

(see python issue #15610).  Cython fixed this as of commit cb40a3e6264b,
released in Cython 0.17 (see output of ``git describe --contains
cb40a3e6264b``).
902441e
Owner

rgommers commented Oct 22, 2012

What's the 2.4 incompatibility? AFAIK Cython 0.16 is broken with 2.4 and 0.17 works again.

Contributor

matthew-brett commented Oct 24, 2012

On Mon, Oct 22, 2012 at 3:25 PM, Ralf Gommers notifications@github.comwrote:

What's the 2.4 incompatibility? AFAIK Cython 0.16 is broken with 2.4 and
0.17 works again.


Reply to this email directly or view it on GitHubhttps://github.com/scipy/scipy/pull/341#issuecomment-9677016.

Was basing it on memory I'm afraid (in Cuba, email access terrible). So,
no problem then...

Owner

rgommers commented Oct 29, 2012

Looks fine. Rebased and merged in 7fade91. Thanks Matthew.

rgommers closed this Oct 29, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment