Issue 3376 : stats f_oneway needs floats #3416

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
5 participants
Contributor

ankit-maverick commented Feb 28, 2014

Fixes #3376

josef-pkt added this to the 0.14.0 milestone Feb 28, 2014

Member

josef-pkt commented Feb 28, 2014

Thanks looks good to me, you could add an integer unit test.

Some possibilities:
I think using float64 is the right thing for stats. I don't know if anyone would want to use low precision with float32 for this but I would think that's unlikely.
However, for machines that can handle it correctly, we could leave higher precision than float64 unchanged. (I never checked and I think on Windows float96 doesn't do anything better than float64).
There are some tougher NIST test cases that f_oneway cannot handle in float64 without rescaling or shifting the data by the user, IIRC.

@rgommers A simple fix that should be quite innocent, I add 0.14 milestone. Reset to 0.15 if it's too late.

Coverage Status

Coverage remained the same when pulling 47016ac on ankit-maverick:issue3376 into 4b4620b on scipy:master.

pv added the PR label Feb 28, 2014

rgommers self-assigned this Feb 28, 2014

@rgommers rgommers modified the milestone: 0.15.0, 0.14.0 Feb 28, 2014

Owner

rgommers commented Feb 28, 2014

@josef-pkt we're really overdue and this isn't critical, so pushing to 0.15.0

@rgommers rgommers added a commit that referenced this pull request Mar 16, 2014

@rgommers rgommers Merge branch 'pr/3416' into master.
Reviewed at #3416
fb99db7
Owner

rgommers commented Mar 16, 2014

Pushed with some minor style changes as fb99db7. Thanks Ankit, Josef.

rgommers closed this Mar 16, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment