Interp2d rectangular fixes #353

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
2 participants
Contributor

jtravs commented Nov 13, 2012

No description provided.

jtravs added some commits Nov 11, 2012

@jtravs jtravs BUG: use fitpack's regrid if possible, fixes #286
Also fixes parts of #1364 (strange warnings not transpose).
Also fixes parts of #1072 (strange behaviour, not lack of
bounds check)
b6bb799
@jtravs jtravs BUG: fix and test ticket #776 and first part of #703
The new regrid backend fixes these cases
469074a
@jtravs jtravs BUG: test for ticket #898 which was fixed with rebase backend
Note that non rectangular grids may still have this bug
2545d61
Owner

pv commented Nov 22, 2012

Looks good to me.

The only thing is that this doesn't actually fix the bugs in the strict sense, but it hides them (calling the same thing with .ravel()ed grid should still cause the old issues). I'll add some comments to the tests to indicate this.

There is also some backward compatibility concern, but I don't think this is an issue since the results will only be more robust than before.

Owner

pv commented Nov 22, 2012

Thanks, merged in 152de29
Please take a look at the small additional changes I made.

pv closed this Nov 22, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment