BUG: special: fix build failure on mingw32 #360

Merged
merged 4 commits into from Nov 18, 2012

Conversation

Projects
None yet
2 participants
@pv
Member

pv commented Nov 18, 2012

The issue is that Cython (0.17 at least) assumes that functions marked "cdef extern" come from external DLL libraries, and appends corresponding declaration attributes. However, this is incorrect in the case of functions in scipy.special. The solution here was to move the declarations to a separate .h file, outside of Cython's control.

Fixes http://projects.scipy.org/scipy/ticket/1773

pv added some commits Nov 18, 2012

BUG: special: fix build failure on mingw32
The issue is that Cython (0.17 at least) assumes that functions marked
"cdef extern" come from external DLL libraries, and appends
corresponding declaration attributes. However, this is incorrect in the
case of functions in scipy.special. The solution here was to move the
declarations to a separate .h file, outside of Cython's control.

rgommers added a commit that referenced this pull request Nov 18, 2012

Merge pull request #360 from pv/fix-mingw
BUG: special: fix build failure on mingw32

@rgommers rgommers merged commit fb28576 into scipy:master Nov 18, 2012

@rgommers

This comment has been minimized.

Show comment Hide comment
@rgommers

rgommers Nov 18, 2012

Member

Works like a charm, thanks!

Member

rgommers commented Nov 18, 2012

Works like a charm, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment