New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed signal.get_window with unicode window name #3946
Conversation
This fails with numpy 1.5.1:
|
@rgommers I am sorry. I did not account for all the combinations of python and numpy and I did not have travis set up. Now that all travis tests pass successfully. Thank you for taking a look into it. |
I'm not too familiar with python 3, but scipy has a forked version of six.py. Would it make sense to use |
I am not familiar enough with the scipy code, thanks @argriffing. Now the diff is much cleaner :-) |
ENH: signal: fixed signal.get_window with unicode window name
Thanks, looks ok. Regression test would be useful, though. |
This minor fix allows unicode objects to be used in scipy.signal.get_window.
This code does not fail anymore (python2):
from scipy.signal import get_window
get_window(u'blackman', 32) # This failed because u'blackman' is not a string on python2.
This code does not fail anymore (python2):
from future import unicode_literals
from scipy.signal import get_window
get_window('blackman', 32) # This failed because u'blackman' is unicode