bug fix for NetCDF endian problem (trac ticket #1720) #471

Merged
merged 1 commit into from Mar 24, 2013

Projects

None yet

3 participants

@eelsirhc

This pull request is an attempt to fix the problem found in trac ticket #1720
( http://projects.scipy.org/scipy/ticket/1720 )

Changeset 76a983e removed the explicit conversion of all outgoing
datatypes into big-endian format (e.g. see page 10 of
http://earthdata.nasa.gov/sites/default/files/esdswg/spg/rfc/esds-rfc-011/ESDS-RFC-011v1.00.pdf)

This changeset (eelsirhc/scipy@d2b5014) converts the type to big-endian during the array creation in createVariable by calling the dtype.newbyteorder
function with the argument "B" for Big endian.

@eelsirhc eelsirhc Convert outgoing netCDF arrays to big-endian
Changeset 76a983e removed the explicit conversion of all outgoing
datatypes into big-endian format (e.g. see page 10 of
http://earthdata.nasa.gov/sites/default/files/esdswg/spg/rfc/esds-rfc-011/ESDS-RFC-011v1.00.pdf)

This changeset converts the type to big-endian during the array
creation in createVariable by calling the dtype.newbyteorder
function with the argument "B" for Big endian.
d2b5014
@pv
SciPy member
pv commented Mar 16, 2013

Looks correct. The test in the ticket should be adapted to a test case.

@pv pv merged commit d2b5014 into scipy:master Mar 24, 2013
@pv
SciPy member
pv commented Mar 24, 2013

Thanks, merged now.

@pv
SciPy member
pv commented Mar 24, 2013

@rgommers: oops, sorry, I didn't see your commit in time...

@rgommers
SciPy member

no problem. guess we're going through the same 0.12 tickets. done for today though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment