Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: rebased mmio refactoring #5133

Merged
merged 32 commits into from Aug 10, 2015

Conversation

Projects
None yet
3 participants
@matthew-brett
Copy link
Contributor

matthew-brett commented Aug 10, 2015

Rebased mmio refactoring by Joscha Reimer, in
#4875.

Added a couple of small refactorings on top.

jor- added some commits May 13, 2015

matthew-brett added some commits Aug 10, 2015

MAINT: removing, refactoring imports in mmio
Removed unused import.  Blank space between import types.  Reformat long
import line.
DOC: rewrite / extend docstrings in mmio.py
Note file-like objects as inputs in some docstrings.

Expand docstring for private function.
@matthew-brett

This comment has been minimized.

Copy link
Contributor Author

matthew-brett commented Aug 10, 2015

@jor- reviewed, tiny formatting changes added to reviewed PR at #4875 - merging.

matthew-brett added a commit that referenced this pull request Aug 10, 2015

Merge pull request #5133 from matthew-brett/mmio-refactor-rebased
MRG: matrix market sparse symmetric matrix support

Currently `scipy.io.mmio.mmwrite` does not support symmetric sparse matrices explicitly. This is currently stored in the `general` structure. The different symmetry structures of the Matrix Market format (`symmetric`, `skew-symmetric` and `hermitian`) are not supported for sparse matrices. With this extension, these are also supported.

The `scipy.io.mmio.MMFile._get_symmetry` method was enhanced so that the symmetry structure of a  sparse matrix is recognized. Furthermore, the `scipy.io.mmio.mmwrite`, `scipy.io.mmio.MMFile.write` and `scipy.io.mmio.MMFile._write` methods were extended by a `symmetry` parameter. Here, the type of the symmetry structure can be passed. If `None` is passed, the symmetry structure is determined. The matrix is stored according to the passed `symmetry` parameter.

@matthew-brett matthew-brett merged commit 5b49895 into scipy:master Aug 10, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jor-

This comment has been minimized.

Copy link
Contributor

jor- commented Aug 10, 2015

@matthew-brett thanks for rebasing.

@rgommers rgommers added this to the 0.17.0 milestone Aug 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.