differential_evolution: improve callback #6907
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As discussed in #6878, I don't think this is the best way to go. We should instead expose an API for the user to control solver iteration. |
dlax
added
needs-decision
|
Based on discussion in the issue gh-6878, it sounds like this is not the preferred approach. Since this has been inactive for a while and there are merge conflicts, I'll go ahead and close it, but feel free to re-open if you're interested in finishing it up (adding tests and documentation). I would also be more comfortable if this were to use features of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exposes
func_val,nfev,nitandpopulationto the user-provided callback function in order to create custom terminators