DOC: Example for signal.cmplx_sort #8481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WarrenWeckesser
added
scipy.signal
Documentation
scipy/signal/signaltools.py
Outdated
| >>> vals = [1, 4, 1+1.j, 3] | ||
| >>> p_sorted, indx = signal.cmplx_sort(vals) | ||
| >>> p_sorted | ||
| array([1.0+0.j, 1.0+1.j, 3.+0.j, 4.+0.j]) |
There was a problem hiding this comment.
Is this the actual output that you get when you display p_sorted? With numpy 1.14.1, I get
array([1.+0.j, 1.+1.j, 3.+0.j, 4.+0.j])
Note that the real parts of the first two values are displayed as 1., not 1.0.
With numpy 1.13.1, I get
array([ 1.+0.j, 1.+1.j, 3.+0.j, 4.+0.j])
There was a problem hiding this comment.
I just checked it and indeed that's not the case.
The output with version 1.8.2 is:
array([ 1.+0.j, 1.+1.j, 3.+0.j, 4.+0.j])
Just as you pointed out. I just pushed desirable changes into this branch.
|
Note that the documentation should agree with the latest numpy release.
Not that whitespace matters that much, but there's an automatic check
that needs to pass, and it may not be smart enough to ignore the
whitespace here.
|
|
After updating numpy I fixed whitespaces to match current version. |
|
Thanks @ziejcow |
adbugger
pushed a commit
to adbugger/scipy
that referenced
this pull request
Mar 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference to: #7168