Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix `setup.py build install egg_info`, which did not previously build #8697

Merged
merged 1 commit into from Apr 12, 2018

Conversation

@eric-wieser
Copy link
Contributor

commented Apr 9, 2018

Fixes numpy/numpy#10646

The original intent was to disable builds when only the egg_info target is requested, not whenever it is one of the targets.

Cherry-picked from numpy/numpy@b8b2a0e

BUG: Fix `setup.py build install egg_info`, which did not previously …
…build

Fixes numpy/numpy#10646

The original intent was to disable builds when _only_ the egg_info target is requested, not whenever it is one of the targets.

Cherry-picked from numpy/numpy@b8b2a0e
@tylerjereddy
Copy link
Contributor

left a comment

I note that @charris eventually merged the matching change into NumPy master, but that there was at least a bit of initial resistance since the command this supports:

python setup.py egg-info build install

is perhaps a bit unusual.

I don't really have a strong opinion, but perhaps @pv should confirm we're in favor of supporting that for scipy.

@eric-wieser

This comment has been minimized.

Copy link
Contributor Author

commented Apr 10, 2018

I'm not necessarily saying we should support it, but the code this changes was not deliberately written to reject it in the way it currently does.

@pv pv merged commit 6999b7d into scipy:master Apr 12, 2018

4 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
codecov/project 76.16% (target 1%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pv pv added this to the 1.1.0 milestone Apr 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.