Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: stats: mode for objects w/ndim > 1 #9646

Merged
merged 1 commit into from Feb 3, 2019
Merged

Conversation

@ev-br
Copy link
Member

ev-br commented Jan 2, 2019

Fix the nan check for the edge case of object arrays with ndim > 1, and possibly string values.

closes gh-9645

Copy link
Member

larsoner left a comment

Other than a corner case maybe (or maybe not) worth considering, LGTM

scipy/stats/stats.py Show resolved Hide resolved
Fix the nan check for the edge case of object arrays
with ndim > 1, and possibly string values.
@ev-br ev-br force-pushed the ev-br:stats_mode_obj branch from 34e83ad to e98ea72 Jan 7, 2019
@ev-br ev-br closed this Jan 14, 2019
@ev-br ev-br reopened this Jan 14, 2019
@rgommers rgommers added this to the 1.3.0 milestone Feb 3, 2019
@rgommers rgommers merged commit affd5d6 into scipy:master Feb 3, 2019
4 of 5 checks passed
4 of 5 checks passed
ci/circleci: pypy3 Your tests failed on CircleCI
Details
ci/circleci: build_docs Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
scipy.scipy Build #20190114.20 succeeded
Details
@rgommers

This comment has been minimized.

Copy link
Member

rgommers commented Feb 3, 2019

LGTM too, merged. Thanks @ev-br

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.