Web/job screen update #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitschang
approved these changes
Sep 17, 2025
Contributor
amitschang
left a comment
amitschang
left a comment
There was a problem hiding this comment.
Sorry for the delay. Looks fine to me, just minor comment, but feel free to ignore
| typeDefs, | ||
| resolvers, | ||
| plugins: process.env.NODE_ENV !== 'production' ? | ||
| schema: process.env.IDIES_ENV === 'test' ? addMocksToSchema( |
Contributor
There was a problem hiding this comment.
Seems this is better called SCISERVER_ENV
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the Job Detail full screen to work differently, from receiving a Job object as a parameter to extracting the Job ID from the URL parameters to query the full job detail from GraphQL. This will allow the use of a
jobs/[id]URL redirection for other uses, like Turbulence Cutout.Testing
Changes can be seen here