New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python 2 compatibility when submitting unicode DOI #56

Merged
merged 3 commits into from Jun 10, 2017

Conversation

2 participants
@jmaupetit
Contributor

jmaupetit commented Jun 8, 2017

Purpose

Submitting a unicode string as a DOI for content negotiation fails on python 2.

Proposal

Fix type detection in content negotiation to split unicode litteral (if any).

See this line.

Remark: we expect the new test to fail with python 2

@jmaupetit jmaupetit force-pushed the jmaupetit:fix-cn-py2-unicode-compat branch from b45bcdd to bb30a56 Jun 8, 2017

jmaupetit added some commits Jun 8, 2017

@jmaupetit jmaupetit force-pushed the jmaupetit:fix-cn-py2-unicode-compat branch from bb30a56 to 3a616fb Jun 8, 2017

@jmaupetit jmaupetit changed the title from WIP: Fix python 2 compatibility when submitting unicode DOI to Fix python 2 compatibility when submitting unicode DOI Jun 8, 2017

@sckott

This comment has been minimized.

Owner

sckott commented Jun 9, 2017

@jmaupetit thx, you originally had WIP - done now?

@jmaupetit

This comment has been minimized.

Contributor

jmaupetit commented Jun 9, 2017

Yes sir!

@sckott

This comment has been minimized.

Owner

sckott commented Jun 10, 2017

thanks very much!

@sckott sckott merged commit 9d0a4e7 into sckott:master Jun 10, 2017

1 of 2 checks passed

coverage/coveralls Coverage pending from Coveralls.io
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sckott sckott added this to the v0.5 milestone Jun 10, 2017

@jmaupetit jmaupetit deleted the jmaupetit:fix-cn-py2-unicode-compat branch Jun 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment