Add PosgreSQL 9.2 image

[mnagy]

It is based on the MySQL image and works similarly. You must set
POSTGRESQL_{USER,PASSWORD,DATABASE} environment variables and can
optionally set the 'postgres' db user password using the
POSTGRESQL_ADMIN_PASSWORD variable.

There are few minor outstanding issues that are marked and commented
with a TODO. Ideas and suggestions would be appreciated.

You can test the image with make test && make test TARGET=rhel7.

Documentation in README is still missing, but wanted early feedback.

[mnagy]

A note about USER. We run this as root, but only thing that really requires root privileges is this chown. I would love to run the whole entrypoint as user postgres. However, we would have to make sure the volume is owned by the postgres user (uid 26).

Any ideas if this is possible?

[mfojtik]

Why not chown in Dockerfile then?

[soltysh]

Nope if you have mounted volume $PGDATA.

[mnagy]

Addressed all issues plus something extra :) PTAL

[mfojtik]

this needs to be tuneable via env var... why is default not enough? can't you set this in postgres config file instead?

[mnagy]

Right, will fix that tomorrow so LANG can be overridden. I might, but setting the LANG var is the simplest way to do it, I didn't see any reason to modify config file because of it. Btw, it mostly affects initdb. And yeah, the default is probably faster a bit, but without utf support, at least that's how I understand it.

[mfojtik]

LGTM. Nice job @mnagy, kudos!

[mnagy]

Some enhancements:
No further need to use scl when doing docker exec, added contrib directory. Added tests for env variable validations, simplified that code a bit as well. PTAL.

[mnagy]

Very small change added. We're now also validating maximum user/db name length. Also added tests for that.

[mnagy]

@jhadvig @soltysh can I get more reviews in addition to @mfojtik's, please?

[jhadvig]

could you maybe do the function declaration in this file more consistent with the test/run script?

[mnagy]

Done. PTAL

[soltysh]

Can you do that also for https://github.com/openshift/mongodb/ and https://github.com/openshift/mysql/, please 😸

[soltysh]

Even more, can you add that to all our images 😅

[mnagy]

@soltysh For mysql, see sclorg/mysql-container#24
For MongoDB, @jhadvig will do that. :)

[soltysh]

many kudos @mnagy

[mnagy]

@soltysh thanks :) I'd also appreciate a certain four-letter acronym :P

[mnagy]

Added SCL info into README.md, few minor fixes. PTAL

[soltysh]

Here's mine LGTM :)

[jhadvig]

@mnagy LGTM, good job :)
Merging

[rhcarvalho]

This uses PASS and USER as global variables, so we're never actually testing the access of the admin user...

[soltysh]

Can you open a bug report against this repo, so it doesn't get forgotten?

[rhcarvalho]

I was wrong. In fact, what happens is that assert_login_access shadows USER and PASS with local variables of the same name, and because in bash local variables are visible in the scope of a function and its children, postgresql_cmd eventually uses those local variables when called from within assert_login_access.

Needless to say, that's very very error prone and hard to reason about...