New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symfony2 projects need to run scripts during assemble phase #73

Closed
phil-pona opened this Issue Dec 6, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@phil-pona

phil-pona commented Dec 6, 2015

I was wondering if the parameter

--no-scripts

in the assemble script can be removed? Since symfony 2 projects run scripts during composer install eg.

  • clearing Cache
  • build Bootstrap
  • install assets of all bundles to the public web directory
  • create app/config/parameters.yml
...
"scripts": {
        "post-install-cmd": [
            "Incenteev\\ParameterHandler\\ScriptHandler::buildParameters",
            "Sensio\\Bundle\\DistributionBundle\\Composer\\ScriptHandler::buildBootstrap",
            "Sensio\\Bundle\\DistributionBundle\\Composer\\ScriptHandler::clearCache",
            "Sensio\\Bundle\\DistributionBundle\\Composer\\ScriptHandler::installAssets",
            "Sensio\\Bundle\\DistributionBundle\\Composer\\ScriptHandler::installRequirementsFile",
            "Sensio\\Bundle\\DistributionBundle\\Composer\\ScriptHandler::prepareDeploymentTarget"
        ],
        "post-update-cmd": [
            "Incenteev\\ParameterHandler\\ScriptHandler::buildParameters",
            "Sensio\\Bundle\\DistributionBundle\\Composer\\ScriptHandler::buildBootstrap",
            "Sensio\\Bundle\\DistributionBundle\\Composer\\ScriptHandler::clearCache",
            "Sensio\\Bundle\\DistributionBundle\\Composer\\ScriptHandler::installAssets",
            "Sensio\\Bundle\\DistributionBundle\\Composer\\ScriptHandler::installRequirementsFile",
            "Sensio\\Bundle\\DistributionBundle\\Composer\\ScriptHandler::prepareDeploymentTarget"
        ]
    },
...

As an alternative solution I would suggest to make an sti-php-symfony image, which is based on either php-55-centos7 or php-56-centos7

@bparees

This comment has been minimized.

Collaborator

bparees commented Dec 18, 2015

I can't think of any particular reason we couldn't remove that... @luciddreamz can you provide any insight here?

@bparees

This comment has been minimized.

Collaborator

bparees commented Dec 18, 2015

got confirmation from @luciddreamz, we'll remove it.

@phil-pona

This comment has been minimized.

phil-pona commented Dec 19, 2015

Thank you for the update

@phil-pona phil-pona closed this Dec 19, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment