Prevent deletion of default branch #1827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdorra
requested changes
Oct 18, 2021
| @@ -0,0 +1,2 @@ | |||
| - type: Changed | |||
| description: The default branch of a repository cannot be deleted ([#1827](https://github.com/scm-manager/scm-manager/pull/1827)) | |||
There was a problem hiding this comment.
Suggested change
| description: The default branch of a repository cannot be deleted ([#1827](https://github.com/scm-manager/scm-manager/pull/1827)) | |
| description: The default branch of a git repository cannot be deleted ([#1827](https://github.com/scm-manager/scm-manager/pull/1827)) |
There was a problem hiding this comment.
This should work for hg, too (though currently it doesn't)
| } | ||
|
|
||
| gitHeadModifier.ensure(repository, newDefaultBranch); | ||
| storeProvider.get(repository).get().setDefaultBranch(newDefaultBranch); |
There was a problem hiding this comment.
Updating the reference of the config does not persist the changes nor triggers update events. You have to call the set method of the store.
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds a pre receive repository hook that prevents the deletion of the default branch.
Mirrored repositories will change their default branches to another branch, when it is deleted.
Your checklist for this pull request
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Contributor:
gradle/changelogor CHANGELOG.md is updated for pluginsReviewer:
Checklist for branch merge request (not required for forks)