Skip to content
This repository has been archived by the owner on Jul 1, 2021. It is now read-only.

Global Storage #26

Merged
merged 2 commits into from Aug 6, 2018
Merged

Global Storage #26

merged 2 commits into from Aug 6, 2018

Conversation

victuxbb
Copy link
Contributor

@victuxbb victuxbb commented Aug 3, 2018

  • Add IFrame initialization inside DIC, is something that we are able to do it in bootstraping of the cmp
  • Move IFrame listener for communication inside DIC
  • Fix tests

* Add IFrame initialization inside DIC, is something that we are able to do it in bootstraping of the cmp
* Move IFrame listener for communication inside DIC
* Fix tests
@codecov-io
Copy link

Codecov Report

Merging #26 into feature/develop-v1.0.0 will decrease coverage by 0.48%.
The diff coverage is 98.03%.

Impacted file tree graph

@@                    Coverage Diff                     @@
##           feature/develop-v1.0.0      #26      +/-   ##
==========================================================
- Coverage                   98.44%   97.95%   -0.49%     
==========================================================
  Files                          29       31       +2     
  Lines                        1159     1225      +66     
  Branches                      110      115       +5     
==========================================================
+ Hits                         1141     1200      +59     
- Misses                         18       25       +7
Impacted Files Coverage Δ
.../cmp/infrastructure/configuration/Configuration.js 100% <100%> (ø) ⬆️
...tructure/controller/iframeCommunicationRegistry.js 100% <100%> (ø) ⬆️
...cmp/infrastructure/service/globalConsentStorage.js 86.66% <100%> (ø)
src/cmp/infrastructure/configuration/defaults.js 100% <100%> (ø) ⬆️
src/cmp/infrastructure/cmpInitializer.js 97.97% <100%> (-2.03%) ⬇️
src/cmp/infrastructure/service/iFrameRegistry.js 93.18% <96.55%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5deef5...c463b48. Read the comment docs.

Copy link
Collaborator

@rafamarquezv rafamarquezv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@victuxbb victuxbb merged commit 24895d6 into feature/develop-v1.0.0 Aug 6, 2018
@victuxbb victuxbb deleted the feature/registerIFrame branch August 6, 2018 08:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants