From aa0d7db736adaa1aaf0f2cb6cc6ee4b503899b25 Mon Sep 17 00:00:00 2001 From: Sal Date: Mon, 11 Apr 2016 16:13:36 -0400 Subject: [PATCH] coverage, dep update --- index.js | 8 ++++++-- package.json | 8 +++++--- test/test.js | 19 +++++++++++++++++++ 3 files changed, 30 insertions(+), 5 deletions(-) diff --git a/index.js b/index.js index 1bcce02..49a19ec 100644 --- a/index.js +++ b/index.js @@ -23,9 +23,13 @@ module.exports = function gulpAngularTpl2js(options) { } tpl2js.inline(buf, fileOptions || {}, function (err, result) { + + if(err) { + done(err); + return; + } + done(null, new Buffer(result)); - }, function (err) { - done(err) }); }); diff --git a/package.json b/package.json index 6f64898..feefd9a 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "gulp-angular-tpl2js", - "version": "0.0.3", + "version": "0.0.4", "description": "Use gulp to convert Angular templates to inline JavaScript", "files": [ "index.js" @@ -17,10 +17,12 @@ "gulp": "^3.9.1", "gulp-istanbul": "^0.10.4", "gulp-mocha": "^2.2.0", - "mocha": "^2.4.5" + "mocha": "^2.4.5", + "vinyl": "^1.1.1", + "vinyl-fs-fake": "^1.1.0" }, "dependencies": { - "angular-tpl2js": "0.0.6", + "angular-tpl2js": "0.0.8", "gulp-util": "^3.0.7", "object-assign": "^4.0.1", "readable-stream": "^2.0.6", diff --git a/test/test.js b/test/test.js index 6a28a70..22a3e53 100644 --- a/test/test.js +++ b/test/test.js @@ -1,6 +1,9 @@ var gulp = require('gulp'); var chai = require('chai'); var tpl2js = require('..'); +var vfsFake = require('vinyl-fs-fake'); +var File = require('vinyl'); +var PluginError = require('gulp-util').PluginError; var expect = chai.expect; chai.should(); @@ -91,4 +94,20 @@ describe('gulp-angular-tpl2js: base functionality', function () { done(); }); }); + + it('should force a plugin error', function (done) { + + var js = new File({ + path: '/', + contents: new Buffer('angular.module(\'mod\').directive(\'dir\', function () { return { scope: {}, templateUrl: \'fixtures/templates/404.html\', link: function (scope, elem, attrs) { } } });') + }); + + vfsFake.src(js) + .pipe(tpl2js()) + .on('error', function (err) { + expect(err).to.exist; + expect(err).to.be.an.instanceof(PluginError); + done(); + }); + }); }); \ No newline at end of file