Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala 2.13.0-M4 #119

Closed
wants to merge 1 commit into from
Closed

Scala 2.13.0-M4 #119

wants to merge 1 commit into from

Conversation

xuwei-k
Copy link
Contributor

@xuwei-k xuwei-k commented Jul 5, 2018

No description provided.

mimaBinaryIssueFilters ++= Seq(
ProblemFilters.exclude[IncompatibleMethTypeProblem]("scodec.DecoderFunctions.decodeCollect"),
Copy link
Contributor

@mpilquist mpilquist Jul 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, these are real binary incompatibilities, right? Requiring us to release scodec-core 1.11?

Copy link
Contributor Author

@xuwei-k xuwei-k Jul 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes real binary incompatibilities 😥

Copy link
Contributor

@smarter smarter Sep 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scala-collection-compat 0.2.0 has been released which should solve the binary incompatibilities: scala/scala-collection-compat#115

@@ -8,9 +8,9 @@ cache:
language: scala

scala:
- 2.10.6
Copy link
Contributor Author

@xuwei-k xuwei-k Jul 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't continue Scala 2.10 support if use scala-collection-compat scala/scala-collection-compat#1

@xuwei-k
Copy link
Contributor Author

@xuwei-k xuwei-k commented Jul 13, 2018

binary compatible version. but some tricky hacks.
xuwei-k@84e5f30

@mpilquist
Copy link
Contributor

@mpilquist mpilquist commented Jul 14, 2018

Wow, awesome! Normally I'd prefer the backwards compatible version but in this case, I'm thinking we release scodec 1.11.0-M1 and drop 2.10 support. That way we don't need our own version of CanBuildFrom. Also, Shapeless is dropping 2.10 support soon as well. What do you think?

@milessabin
Copy link

@milessabin milessabin commented Jul 15, 2018

FYI: shapeless support for 2.10 will continue for 2.3.x ... I won't be dropping 2.10 support until 2.4.0.

@mpilquist
Copy link
Contributor

@mpilquist mpilquist commented Sep 26, 2018

Not really sure how to proceed here. I think we should maintain 2.13 support on a branch until the final release, so as to avoid introducing binary compatibility problems on the 2.11 or 2.12 builds as a result of changes in scala-collection-compat.

@mpilquist
Copy link
Contributor

@mpilquist mpilquist commented Jan 21, 2019

Merged as part of #138

@mpilquist mpilquist closed this Jan 21, 2019
@xuwei-k xuwei-k deleted the 2.13.0-M4 branch Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants