Minor edits to README.md (mostly formatting) #110

merged 2 commits into from Jan 26, 2017


None yet

2 participants

Zearin commented Jan 25, 2017

No description provided.

A. If your `command_not_found_handler` function is not intended to
address (possibly missing) commands invoked during bash
- programmable completion functions, you can take that into account
- in your function for example by testing if the `$COMP_`* variables
+ programmable completion functions. You can account for this
scop Jan 26, 2017 Owner

Replacing the comma with the period and splitting the sentence like that (before "You") seems clunky here. Was this intentional? Or did you also intend to remove the "If" from the start of the sentence?

Zearin Jan 26, 2017 Contributor

Whoops—I agree. I think I was looking at the effect on the second sentence, but forgot to check the first. I’ll fix shortly!

A. Absolutely not. zsh has an extremely sophisticated completion system
that offers many features absent from the bash implementation. Its
users often cannot resist pointing this out. More information can
- be found at: http://www.zsh.org/
+ be found at: http://www.zsh.org
scop Jan 26, 2017 Owner

I'd rather leave this as it was, with the trailing slash.

Zearin Jan 26, 2017 Contributor


@scop scop merged commit 23cc43b into scop:master Jan 26, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
scop commented Jan 26, 2017


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment