Fixe lvm completion related with physical volumes #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 8, 2016 11:21
_lvm_physicalvolumes() only gets PVs that belong to a VG. In some cases like pvremove we can use all PVs including those not included in any VGs. So we add a new function _lvm_physicalvolumes_all() to get all PVs, and fix all the commands that need to use _lvm_physicalvolumes_all() instead of _lvm_physicalvolumes(). Signed-off-by: Liuhua Wang <lwang@suse.com> Reviewed-by: Lidong Zhong <lzhong@suse.com>
Add _lvm_filedir() to use _filedir except set $cur to /dev when $cur is empty. Signed-off-by: Liuhua Wang <lwang@suse.com> Reviewed-by: Lidong Zhong <lzhong@suse.com>
scop
added a commit
that referenced
this pull request
Mar 9, 2016
Fixe lvm completion related with physical volumes
|
I'm not a lvm user myself, but the changes look sane on surface, so applied. Thanks. |
Best, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The current lvm completion has problems when executing the commands related with physical volumes.
These 3 patches correct completion of all lvm commands related with physical volumes.