New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible Scala 2.13 regression - Seq semantics changed #218

Closed
Sciss opened this Issue Dec 14, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@Sciss
Copy link

Sciss commented Dec 14, 2018

So now unqualified

def parse(args: Seq[String], init: C): Option[C]

suddently means

def parse(args: scala.collection.immutable.Seq[String], init: C): Option[C]

And consequently the standard case of passing in the Array[String] from main creates a problem:

Warning:(61, 30) method copyArrayToImmutableIndexedSeq in class LowPriorityImplicits2 is deprecated (since 2.13.0): Implicit conversions from Array to immutable.IndexedSeq are implemented by copying; Use the more efficient non-copying ArraySeq.unsafeWrapArray or an explicit toIndexedSeq call
  val config  = parser.parse(args, Config()) getOrElse sys.exit(1)

So it should probably be qualified as scala.collection.Seq to match Scala 2.11 and 2.12 behaviour.

@eed3si9n

This comment has been minimized.

Copy link
Member

eed3si9n commented Dec 14, 2018

Sounds good. Would you like to send a PR for this?

@eed3si9n

This comment has been minimized.

Copy link
Member

eed3si9n commented Dec 17, 2018

I just sent #221

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment