Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated dependencies & Removed vulnerabilities #54

Merged
merged 1 commit into from
Nov 5, 2018
Merged

Updated dependencies & Removed vulnerabilities #54

merged 1 commit into from
Nov 5, 2018

Conversation

angeryrohan
Copy link
Contributor

@angeryrohan angeryrohan commented Nov 4, 2018 •
edited
Loading

Fixes: #54

  1. Cron was missing from the dependencies, causing a build fail.

missing cron

  1. Successfully installed cron but found 13 vulnerabilities.

vulneribilities

  1. Dependency version were outdated. Changed them to latest versions. Also 'jade' was recently deprecated and 'pug' was officially declared as it's successor. Removed 'jade', installed pug.

@angeryrohan
Updated dependencies & Removed vulnerabilities
77d33ec 
- Updated all version inside package.json

- Removed jade and installed pug

- Succesfully built and hosted the Dashboard
@angeryrohan angeryrohan mentioned this pull request Nov 4, 2018
Closed
@chamathsilva chamathsilva merged commit 9720b40 into scorelab:master Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chamathsilva chamathsilva chamathsilva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@angeryrohan @chamathsilva