Permalink
Browse files

Merge pull request #3 from scottgonzalez/interactions

Draggable: Use ._bind().
  • Loading branch information...
2 parents 6ea6c47 + c4df289 commit 1cb5b8758980632453cd9bd595b53d633cc22daf @DaveStein DaveStein committed Oct 14, 2011
Showing with 6 additions and 10 deletions.
  1. +6 −10 ui/jquery.ui.draggable.js
View
@@ -45,8 +45,7 @@ $.widget( "ui.draggable", {
this.element.css( "position", "relative" );
}
- // TODO: use _bind()
- this.element.bind( "mousedown." + this.widgetName, $.proxy( this, "_mouseDown" ) );
+ this._bind({ mousedown: "_mouseDown" });
},
// TODO: why is relative handled differently than fixed/absolute?
@@ -133,11 +132,10 @@ $.widget( "ui.draggable", {
// TODO: allow modifying position, just like during drag
this._trigger( "start", event, this._uiHash() );
- // TODO: use ._bind()
- // TODO: rename _bind() to _on(); add _off()
- this.doc
- .bind( "mousemove." + this.widgetName, $.proxy( this, "_mouseMove" ) )
- .bind( "mouseup." + this.widgetName, $.proxy( this, "_mouseUp" ) );
+ this._bind( this.doc, {
+ mousemove: "_mouseMove",
+ mouseup: "_mouseUp"
+ });
},
_mouseMove: function( event ) {
@@ -205,9 +203,7 @@ $.widget( "ui.draggable", {
this.dragEl.remove();
}
- this.doc
- .unbind( "mousemove." + this.widgetName )
- .unbind( "mouseup." + this.widgetName );
+ this.doc.unbind( "." + this.widgetName );
},
_uiHash: function( event ) {

0 comments on commit 1cb5b87

Please sign in to comment.