Em support #72

Closed
wants to merge 7 commits into
from

Projects

None yet

3 participants

@NetEffect

I think I have fixed the EM support. Here is what I have done:

  1. Updated all media queries to accurate EMs based on a 16px default font-size on browser.
  2. Updated regex to allow for decimals in the min/max-width declarations
  3. Changed the eminpx calculations to find the offsetWidth of a DIV with width: 1em
  4. Cleaned up the code which converted ems to pxs
  5. Changed the styles for P tags to use EM based width

Tested in IE7, IE8

Sorry for all the commits... I was switching back and forth between master and em-support... should have stashed my changes instead of committing them. Let me know what you think.

scottjehl and others added some commits Sep 23, 2011
scottjehl rough pass at em unit support in media queries 2ad79c9
scottjehl updated test css to demo em queries 013166d
Ryan Wheale Updated media queries to use more accurate EMs and used EMs for parag…
…raph width to allow for a more accurate testing environment
ef54fc7
Ryan Wheale Updated media queries to use more accurate EMs and used EMs for parag…
…raph width to allow for a more accurate testing environment
86c2441
Ryan Wheale updated media queries to use more accurate EMs, updated paragraphs to…
… use EM-based width, discovered discrepancy when using px AND em for media queries
6d6f310
Ryan Wheale Almost done - getting close 9a93ca1
Ryan Wheale Updated Regex to support decimals, changed calculation for eminpix, c…
…leaned up the math for min/max calculations, update paragraph tags to use EM based widths as opposed to pixels for more accurate testing
f56d351
@olaf-jan

I tested this on IE8, and it works perfectly.

@scottjehl
Owner

Just getting to this now, I'll check it out and get back to you shortly, hopefully with a merge! :)

@scottjehl
Owner

All rolled into the em-support branch now and updated. Thanks for the great work. I'm closing this out and we'll look to roll it into master asap!

@scottjehl scottjehl closed this Jan 16, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment