changed whitespace to match existing style, and added test case for p…

…arentless srcset img element
scottjehl · Feb 4, 2015 · 59566bf · 59566bf
1 parent 0814979
commit 59566bf
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/dist/picturefill.js b/dist/picturefill.js
@@ -601,7 +601,7 @@ window.matchMedia || (window.matchMedia = function() {
 			}
 
 			// Cache and remove `srcset` if present and we’re going to be doing `picture`/`srcset`/`sizes` polyfilling to it.
-			if ( (parent && parent.nodeName.toUpperCase() === "PICTURE") ||
+			if ( ( parent && parent.nodeName.toUpperCase() === "PICTURE" ) ||
 			( element.srcset && !pf.srcsetSupported ) ||
 			( !pf.sizesSupported && ( element.srcset && element.srcset.indexOf("w") > -1 ) ) ) {
 				pf.dodgeSrcset( element );

diff --git a/src/picturefill.js b/src/picturefill.js
@@ -552,7 +552,7 @@
 			}
 
 			// Cache and remove `srcset` if present and we’re going to be doing `picture`/`srcset`/`sizes` polyfilling to it.
-			if ( (parent && parent.nodeName.toUpperCase() === "PICTURE") ||
+			if ( ( parent && parent.nodeName.toUpperCase() === "PICTURE" ) ||
 			( element.srcset && !pf.srcsetSupported ) ||
 			( !pf.sizesSupported && ( element.srcset && element.srcset.indexOf("w") > -1 ) ) ) {
 				pf.dodgeSrcset( element );

diff --git a/tests/tests.js b/tests/tests.js
@@ -582,4 +582,14 @@
 
 	});
 
+	test( "`img` can be added outside the DOM without errors", function() {
+		var img = document.createElement( "img" );
+
+		img.setAttribute( "srcset", "data:img 500w" );
+
+		picturefill( { elements: [ img ] } );
+
+		assert.equal( img.currentSrc || img.src, "data:img" );
+	});
+
 })( window, jQuery );