Adds support for -based resolution switching on source elements. #18

Closed
wants to merge 6 commits into
from

Projects

None yet

3 participants

@Wilto
Collaborator
Wilto commented Jun 16, 2012

Adds srcset-based resolution switching on source elements, per the markup pattern proposed here: http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2012-May/036160.html

@scottjehl
Owner

Nice work! Let's chat soon about where best to keep this change (master? branch? etc)

On Jun 16, 2012, at 5:18 PM, Mat Marquis wrote:

Adds srcset-based resolution switching on source elements, per the markup pattern proposed here: http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2012-May/036160.html

You can merge this Pull Request by running:

git pull https://github.com/Wilto/picturefill florians-compromise

Or you can view, comment on it, or merge it online at:

#18

-- Commit Summary --

  • Adds support for -based resolution switching on source elements.

-- File Changes --

M external/imgs/extralarge.jpg (0)
A external/imgs/extralarge2x.jpg (0)
M external/imgs/large.jpg (0)
A external/imgs/large2x.jpg (0)
M external/imgs/medium.jpg (0)
A external/imgs/medium2x.jpg (0)
M external/imgs/small.jpg (0)
A external/imgs/small2x.jpg (0)
M index.html (55)
M picturefill.js (32)

-- Patch Links --

https://github.com/scottjehl/picturefill/pull/18.patch
https://github.com/scottjehl/picturefill/pull/18.diff


Reply to this email directly or view it on GitHub:
#18

@Wilto
Collaborator
Wilto commented Jun 16, 2012

Thanks, dude! A branch probably makes the most sense, but we can sort it out later.

@digerata
digerata commented Oct 6, 2012

Does anyone know the status on this pull request? It seems supremely useful...

@scottjehl
Owner

This branch should either be updated to the new source or dropped for a while, since it's mostly syntactic sugar on top of something already possible (I think?). Thoughts, @Wilto ? Closing the PR at least for now.

@scottjehl scottjehl closed this Jun 26, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment