Fixing Regex to work with multiple Media Query rules

[paulomunoz]

Fixing Regex to work with multiple Media Query rules, like: "(min-height: 900px) and (min-width: 992px) 150px"

[paulomunoz]

I found this limitation while trying to execute the following code:

<img src="assets/img/ef-logo-200.png" alt="EF Education First" 
                sizes="(min-height: 900px) and (min-width: 992px) 150px,(min-width:768px) 100px, 60px"
                srcset="assets/img/ef-logo-60.png 60w,
                      assets/img/ef-logo-100.png 100w,
                      assets/img/ef-logo-120.png 120w,
                      assets/img/ef-logo-200.png 200w" />

I fixed the regular expression but I wasn't sure which branch I should request a pull to, did it for Master but let me know if I should do it for a different branch.

On Chrome (which has HTMLPictureElement) it works fine, but on Firefox for example, the rule (min-height: 900px) and (min-width: 992px) 150px was never working. Now it seems to be fine, I tried to test some other variations and it all seems to be ok now. Please let me know if you find any problem.

Thanks,
Paulo

[albell]

Yeah, much needed. But... my parser rewrite in the PF3 proposal handles all these cases correctly, and more, and much closer to spec. So +1 but we ought to think about when we're going to shift energy towards PF3 proposal.

[Wilto]

+1 from me as well.

@baloneysandwiches: you, me, @aFarkas, and the rest of the team should block out a little time next week to talk about where things stand on the PF3 proposal. Once you guys are feeling pretty good about a 3.0.0, I want to get some dedicated beta testing volunteers. This one is gonna be too big to just chuck out there like “okay, so, everybody test this when you get a sec.”

[aFarkas]

We already have something like this in our 2.4 branch. Can you check whether this solves your problem. See: https://github.com/scottjehl/picturefill/blob/2.4/src/picturefill.js#L183

[mike-engel]

@paulomunoz If you get some time, can you checkout our 2.4 branch, or 3.0-beta to see if the updates are what you're looking for?

[aFarkas]

I think we can close this.