on FF 3.6 with no flash, onLoad event is not triggered #40

Merged
merged 2 commits into from Nov 9, 2013

Conversation

Projects
None yet
2 participants
@jgabios
Contributor

jgabios commented Oct 8, 2013

code to reproduce the error:
soundManager.createSound({
id: 'mysound',
url: '/sounds/mysound.ogg',
autoLoad: true,
autoPlay: true,
onload: function(){
alert('loaded');
}
});
adding s._a.load(); on line 2937, triggers the onload event.

jgabios added some commits Oct 8, 2013

on FF 3.6 with no flash, onLoad event is not triggered
code to reproduce the error:
                    soundManager.createSound({
                        id: 'mysound',
                        url: '/sounds/mysound.ogg',
                        autoLoad: true,
                        autoPlay: true,
                        onload: function(){
                           alert('loaded');
                                }
                    });
adding s._a.load(); on line 2937, triggers the onload event.
_docElement is always false
I looked for documentation on _docElement, but there is none.
I guess it was meant doc.documentElement to get to the HTML root element, but otherwise going from body directly to the first DIV seems reasonable enough.
@scottschiller

This comment has been minimized.

Show comment Hide comment
@scottschiller

scottschiller Nov 9, 2013

Thanks - this was probably a typo where I added . and in previous times, there was a _docElement referring to the document itself.

FF 3.6 is ancient, but I'll review and leave this change in provided it doesn't cause any regressions for HTML5 clients.

Thanks - this was probably a typo where I added . and in previous times, there was a _docElement referring to the document itself.

FF 3.6 is ancient, but I'll review and leave this change in provided it doesn't cause any regressions for HTML5 clients.

scottschiller added a commit that referenced this pull request Nov 9, 2013

Merge pull request #40 from jgabios/master
on FF 3.6 with no flash, onLoad event is not triggered

@scottschiller scottschiller merged commit fc6ef46 into scottschiller:master Nov 9, 2013

@scottschiller

This comment has been minimized.

Show comment Hide comment
@scottschiller

scottschiller Dec 1, 2013

Owner

This has been merged and is now on SM2 master - thanks!
V2.97a.20130512...V2.97a.20131201

Owner

scottschiller commented on a998e44 Dec 1, 2013

This has been merged and is now on SM2 master - thanks!
V2.97a.20130512...V2.97a.20131201

@scottschiller

This comment has been minimized.

Show comment Hide comment
@scottschiller

scottschiller Dec 1, 2013

Owner

This has been merged and is now on SM2 master - thanks!
V2.97a.20130512...V2.97a.20131201

Owner

scottschiller commented on c9a6a1c Dec 1, 2013

This has been merged and is now on SM2 master - thanks!
V2.97a.20130512...V2.97a.20131201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment