New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Squash bugs before Auth release #136

Closed
RyanTG opened this Issue Nov 24, 2016 · 35 comments

Comments

Projects
None yet
2 participants
@RyanTG
Collaborator

RyanTG commented Nov 24, 2016

I'm stuck on trying to fix some bugs. I think I've hit the limits of my capabilities, and we need some expert brains on this before we release it.

One thing that may be important: I was fairly gung ho about changing to SDK version to 24, and updating some dependencies. Since I updated those, there are now new versions available (25, and play services 9.8). When I upgrade to those newest ones, more bugs come up (in api 25, it can't find location). So I'm not going to update them anymore (aka I reverted it, so we're still at 24). However, I wonder if I brought it to 24 without adequately accounting for everything.

Here are the bugs I'm getting:

  • On my device (OnePlus X, using API 24), with the app downloaded through the play store, the app crashes when I do any sort of lookup. Error:

    java.lang.NullPointerException: Attempt to invoke virtual method 'void android.support.v7.widget.SearchView.setSearchableInfo(android.app.SearchableInfo)' on a null object reference
    at com.pbm.p.onCreateOptionsMenu(Unknown Source)
    at com.pbm.LocationLookupDetail.onCreateOptionsMenu(Unknown Source)
    at android.app.Activity.onCreatePanelMenu(Activity.java:2852)
    at android.support.v4.app.o.onCreatePanelMenu(Unknown Source)
    at android.support.v7.view.i.onCreatePanelMenu(Unknown Source)
    at android.support.v7.app.g$a.onCreatePanelMenu(Unknown Source)
    at android.support.v7.app.l.b(Unknown Source)
    at android.support.v7.app.l.f(Unknown Source)
    at android.support.v7.app.l$1.run(Unknown Source)
    at android.os.Handler.handleCallback(Handler.java:739)
    at android.os.Handler.dispatchMessage(Handler.java:95)
    at android.os.Looper.loop(Looper.java:148)
    at android.app.ActivityThread.main(ActivityThread.java:5461)
    at java.lang.reflect.Method.invoke(Native Method)
    at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)

If you go to Profile, and then click on a location that that user has edited, then you can see the location detail for a location (just noting this, because at first I wondered if the error was somehow due to the No Data bug - but it's not).

  • With API 25, in the emulator, I get this error when I do a location lookup:

    java.lang.RuntimeException: android.os.TransactionTooLargeException: data parcel size 598240 bytes

@scottwainstock

This comment has been minimized.

Show comment
Hide comment
@scottwainstock

scottwainstock Nov 25, 2016

Owner

Click the map button on a page with >1 locations:

java.lang.ClassCastException: java.lang.Object[] cannot be cast to com.pbm.Location[]
at com.pbm.DisplayOnMap.onMapReady(DisplayOnMap.java:52)
at com.google.android.gms.maps.MapFragment$zza$1.zza(Unknown Source)
at com.google.android.gms.maps.internal.zzt$zza.onTransact(Unknown Source)
at android.os.Binder.transact(Binder.java:387)
at yd.a(:com.google.android.gms.DynamiteModulesB:82)
at maps.ad.t$5.run(Unknown Source)
at android.os.Handler.handleCallback(Handler.java:739)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:148)
at android.app.ActivityThread.main(ActivityThread.java:5417)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)

Owner

scottwainstock commented Nov 25, 2016

Click the map button on a page with >1 locations:

java.lang.ClassCastException: java.lang.Object[] cannot be cast to com.pbm.Location[]
at com.pbm.DisplayOnMap.onMapReady(DisplayOnMap.java:52)
at com.google.android.gms.maps.MapFragment$zza$1.zza(Unknown Source)
at com.google.android.gms.maps.internal.zzt$zza.onTransact(Unknown Source)
at android.os.Binder.transact(Binder.java:387)
at yd.a(:com.google.android.gms.DynamiteModulesB:82)
at maps.ad.t$5.run(Unknown Source)
at android.os.Handler.handleCallback(Handler.java:739)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:148)
at android.app.ActivityThread.main(ActivityThread.java:5417)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)

@RyanTG

This comment has been minimized.

Show comment
Hide comment
@RyanTG

RyanTG Nov 25, 2016

Collaborator

You can access the lookup results view (so you can click a map button for multiple locations)? I can't get that far on the beta.

Collaborator

RyanTG commented Nov 25, 2016

You can access the lookup results view (so you can click a map button for multiple locations)? I can't get that far on the beta.

@scottwainstock

This comment has been minimized.

Show comment
Hide comment
@scottwainstock

scottwainstock Nov 25, 2016

Owner

I fixed that issue. Commits/new beta coming tonight. I'm just looking at the API 25 thing right now.

Here was the "java.lang.NullPointerException: Attempt to invoke virtual method 'void android.support.v7.widget.SearchView.setSearchableInfo(android.app.SearchableInfo)' on a null object reference" issue:
http://stackoverflow.com/a/23840049

I had to add proguard to get the app to compile (we've added a lot of 3rd party libraries and were getting a "too many methods" error). So, it's super unlikely this would have been on your mind during debugging.

Owner

scottwainstock commented Nov 25, 2016

I fixed that issue. Commits/new beta coming tonight. I'm just looking at the API 25 thing right now.

Here was the "java.lang.NullPointerException: Attempt to invoke virtual method 'void android.support.v7.widget.SearchView.setSearchableInfo(android.app.SearchableInfo)' on a null object reference" issue:
http://stackoverflow.com/a/23840049

I had to add proguard to get the app to compile (we've added a lot of 3rd party libraries and were getting a "too many methods" error). So, it's super unlikely this would have been on your mind during debugging.

@RyanTG

This comment has been minimized.

Show comment
Hide comment
@RyanTG

RyanTG Nov 25, 2016

Collaborator

This Thanksgiving, I'm thankful for you squashing bugs.

I saw something about proguard in an SO answer... But it just felt to like too much for me. Glad you found the answer!

Collaborator

RyanTG commented Nov 25, 2016

This Thanksgiving, I'm thankful for you squashing bugs.

I saw something about proguard in an SO answer... But it just felt to like too much for me. Glad you found the answer!

@scottwainstock

This comment has been minimized.

Show comment
Hide comment
@scottwainstock

scottwainstock Nov 25, 2016

Owner

The API 25 issue seems huge:
http://stackoverflow.com/questions/39507250/why-does-android-n-throw-transactiontoolargeexception-when-using-bundles

I don't have a fix for it right now, and it sounds like it's going to be a lot of work.

I'll send an updated beta that fixes the other two issues.

Owner

scottwainstock commented Nov 25, 2016

The API 25 issue seems huge:
http://stackoverflow.com/questions/39507250/why-does-android-n-throw-transactiontoolargeexception-when-using-bundles

I don't have a fix for it right now, and it sounds like it's going to be a lot of work.

I'll send an updated beta that fixes the other two issues.

@RyanTG

This comment has been minimized.

Show comment
Hide comment
@RyanTG

RyanTG Nov 25, 2016

Collaborator

Sweet! Working great on my phone. Thanks for the fixes. I was worried that I had introduced problems.

I'll check on this some more: I had to quit the app multiple times before it actually quit.

Now I need to take the "map of nearby" screenshot when I'm not at someone's home.

Collaborator

RyanTG commented Nov 25, 2016

Sweet! Working great on my phone. Thanks for the fixes. I was worried that I had introduced problems.

I'll check on this some more: I had to quit the app multiple times before it actually quit.

Now I need to take the "map of nearby" screenshot when I'm not at someone's home.

@RyanTG

This comment has been minimized.

Show comment
Hide comment
@RyanTG

RyanTG Dec 6, 2016

Collaborator

I installed Android 7.1 on my phone (nougat). This is the only crash I've experienced so far:

java.lang.NullPointerException: Attempt to invoke virtual method 'float android.location.Location.distanceTo(android.location.Location)' on a null object reference
at com.pbm.e.a(Unknown Source)
at com.pbm.Profile.d(Unknown Source)
at com.pbm.Profile$2.run(Unknown Source)
at java.lang.Thread.run(Thread.java:761)

It occurred when I viewed the Profile. And it occurred because: I allowed the app access to my Location, and it didn't find it! The locations had no distance listed. In the past when similar things have happened, I've found that I can get it to find my location by opening the profile. But this time the app crashed. HOWEVER, when I reopened it, it had my location.

So I think there's something happening with that initial location request, where it gets access to the location but doesn't actually find it.

Collaborator

RyanTG commented Dec 6, 2016

I installed Android 7.1 on my phone (nougat). This is the only crash I've experienced so far:

java.lang.NullPointerException: Attempt to invoke virtual method 'float android.location.Location.distanceTo(android.location.Location)' on a null object reference
at com.pbm.e.a(Unknown Source)
at com.pbm.Profile.d(Unknown Source)
at com.pbm.Profile$2.run(Unknown Source)
at java.lang.Thread.run(Thread.java:761)

It occurred when I viewed the Profile. And it occurred because: I allowed the app access to my Location, and it didn't find it! The locations had no distance listed. In the past when similar things have happened, I've found that I can get it to find my location by opening the profile. But this time the app crashed. HOWEVER, when I reopened it, it had my location.

So I think there's something happening with that initial location request, where it gets access to the location but doesn't actually find it.

@scottwainstock

This comment has been minimized.

Show comment
Hide comment
@scottwainstock

scottwainstock Dec 6, 2016

Owner
Owner

scottwainstock commented Dec 6, 2016

@RyanTG

This comment has been minimized.

Show comment
Hide comment
@RyanTG

RyanTG Dec 6, 2016

Collaborator

Yes, this is the latest beta build. I installed it from the play store. I haven't experienced the too much data error yet.

Collaborator

RyanTG commented Dec 6, 2016

Yes, this is the latest beta build. I installed it from the play store. I haven't experienced the too much data error yet.

@RyanTG

This comment has been minimized.

Show comment
Hide comment
@RyanTG

RyanTG Dec 7, 2016

Collaborator

Finally got the "TransactionTooLargeException" error on my phone, using Android N. It didn't occur until after I switched from the beta to a version that I pushed to my phone from AS (though that doesn't necessary mean I wouldn't have gotten it while in the beta). Then I fooled around for a bit and got it.

From that fooling around, I've found that I can't produce that crash in the LA region, but I can in Portland. So, my assumption is that it has something to do with the quantity of locations that are loaded when you click "lookup by location". If that's the case, then a possible solution may be to limit the amount of results until you scroll to the bottom of the list. Like, load 25, scroll down, load 25 more...?

Collaborator

RyanTG commented Dec 7, 2016

Finally got the "TransactionTooLargeException" error on my phone, using Android N. It didn't occur until after I switched from the beta to a version that I pushed to my phone from AS (though that doesn't necessary mean I wouldn't have gotten it while in the beta). Then I fooled around for a bit and got it.

From that fooling around, I've found that I can't produce that crash in the LA region, but I can in Portland. So, my assumption is that it has something to do with the quantity of locations that are loaded when you click "lookup by location". If that's the case, then a possible solution may be to limit the amount of results until you scroll to the bottom of the list. Like, load 25, scroll down, load 25 more...?

@scottwainstock

This comment has been minimized.

Show comment
Hide comment
@scottwainstock

scottwainstock Dec 7, 2016

Owner
Owner

scottwainstock commented Dec 7, 2016

@RyanTG

This comment has been minimized.

Show comment
Hide comment
@RyanTG

RyanTG Dec 7, 2016

Collaborator

After more testing:

In Los Angeles, it does crash, but only on the Lookup by Operator view (there are only like five operators listed, but it still crashes on that view).

In Portland, it seems to crash on ALL of the lookups. Same for bay area.

Smaller regions, like Albuquerque, do not crash. I guess we knew this already, but there's definitely a relationship between the size of the region (data-wise) and the crashes. Los Angeles is a little strange, but that's basically still consistent.

Collaborator

RyanTG commented Dec 7, 2016

After more testing:

In Los Angeles, it does crash, but only on the Lookup by Operator view (there are only like five operators listed, but it still crashes on that view).

In Portland, it seems to crash on ALL of the lookups. Same for bay area.

Smaller regions, like Albuquerque, do not crash. I guess we knew this already, but there's definitely a relationship between the size of the region (data-wise) and the crashes. Los Angeles is a little strange, but that's basically still consistent.

@RyanTG

This comment has been minimized.

Show comment
Hide comment
@RyanTG

RyanTG Jan 31, 2017

Collaborator

This is resolved. See the comment below.

App is crashing, but I think it's for a different reason. Note, that "Failed to find provider info" error comes up regularly, even when the app isn't crashing - might just be something with my phone and my weird custom ROM.

I was using the app just fine in the Los Angeles region. Then I switched to Portland and got this. Now it happens every time it starts up. Takes a reinstall to get it working again.

I'm using Android M. And the error looks like the issue is a null value for a high score...? Or maybe a null value somewhere else...

D/AppTracker: App Event: stop
E/AndroidRuntime: FATAL EXCEPTION: Thread-1506
Process: com.pbm, PID: 25956
java.lang.NumberFormatException: Invalid long: "null"
at java.lang.Long.invalidLong(Long.java:124)
at java.lang.Long.parse(Long.java:363)
at java.lang.Long.parseLong(Long.java:353)
at java.lang.Long.parseLong(Long.java:321)
at com.pbm.PBMApplication.initializeMachineScores(PBMApplication.java:442)
at com.pbm.PBMApplication.initializeData(PBMApplication.java:398)
at com.pbm.InitializingScreen$SplashThread.run(InitializingScreen.java:38)
E/AbstractTracker: Can't create handler inside thread that has not called Looper.prepare()
D/AppTracker: App Event: crash

Collaborator

RyanTG commented Jan 31, 2017

This is resolved. See the comment below.

App is crashing, but I think it's for a different reason. Note, that "Failed to find provider info" error comes up regularly, even when the app isn't crashing - might just be something with my phone and my weird custom ROM.

I was using the app just fine in the Los Angeles region. Then I switched to Portland and got this. Now it happens every time it starts up. Takes a reinstall to get it working again.

I'm using Android M. And the error looks like the issue is a null value for a high score...? Or maybe a null value somewhere else...

D/AppTracker: App Event: stop
E/AndroidRuntime: FATAL EXCEPTION: Thread-1506
Process: com.pbm, PID: 25956
java.lang.NumberFormatException: Invalid long: "null"
at java.lang.Long.invalidLong(Long.java:124)
at java.lang.Long.parse(Long.java:363)
at java.lang.Long.parseLong(Long.java:353)
at java.lang.Long.parseLong(Long.java:321)
at com.pbm.PBMApplication.initializeMachineScores(PBMApplication.java:442)
at com.pbm.PBMApplication.initializeData(PBMApplication.java:398)
at com.pbm.InitializingScreen$SplashThread.run(InitializingScreen.java:38)
E/AbstractTracker: Can't create handler inside thread that has not called Looper.prepare()
D/AppTracker: App Event: crash

@RyanTG

This comment has been minimized.

Show comment
Hide comment
@RyanTG

RyanTG Jan 31, 2017

Collaborator

I think this is resolved. See the comment below.

There's also an error when I change regions. Right when I click "change region" and it sends me back to the login page (this is when I am using the app as a guest), I get this error. But the app doesn't crash.

The solution might have something to do with dismissing a dialog (such as the options menu) when the item is clicked). http://stackoverflow.com/questions/2850573/activity-has-leaked-window-that-was-originally-added

Collaborator

RyanTG commented Jan 31, 2017

I think this is resolved. See the comment below.

There's also an error when I change regions. Right when I click "change region" and it sends me back to the login page (this is when I am using the app as a guest), I get this error. But the app doesn't crash.

The solution might have something to do with dismissing a dialog (such as the options menu) when the item is clicked). http://stackoverflow.com/questions/2850573/activity-has-leaked-window-that-was-originally-added

@RyanTG

This comment has been minimized.

Show comment
Hide comment
@RyanTG

RyanTG Feb 1, 2017

Collaborator

I think this error when changing regions:

E/WindowManager: android.view.WindowLeaked: Activity com.pbm.PBMMenu has leaked window android.widget.PopupWindow$PopupDecorView{3a88c36 V.E...... .......D 0,0-539,1188} that was originally added here

is resolved with cf992b6

Perhaps there's another way to do it. But that's all I could figure out.

Collaborator

RyanTG commented Feb 1, 2017

I think this error when changing regions:

E/WindowManager: android.view.WindowLeaked: Activity com.pbm.PBMMenu has leaked window android.widget.PopupWindow$PopupDecorView{3a88c36 V.E...... .......D 0,0-539,1188} that was originally added here

is resolved with cf992b6

Perhaps there's another way to do it. But that's all I could figure out.

@RyanTG

This comment has been minimized.

Show comment
Hide comment
@RyanTG

RyanTG Feb 1, 2017

Collaborator

Woohoo! Resolved this error: #136 (comment)

So, java.lang.NumberFormatException: Invalid long: "null" was occurring when loading Portland because the region contained a few - scores. Like, scores with no value. I think these were entered by @scottwainstock recently.

Example: Marie's Lounge's Dirty Harry: by Unknown on Sat, 28 Jan 2017 00:54:08 +0000

Even though it says Unknown, sswtest was adding scores to the same machine around this same time (testing the quintillion point score). So these blank scores seem to be a result of your testing.

But now that's fixed, right? I think people won't be able to enter blank scores. When I enter a blank score in the Android app, it says "Thanks for updating that machine." but nothing is added (note, it should probably give an error, AND valid scores should probably say "Thanks for entering that score." But that's another issue...)

Anyway, as long as no one can ever enter a blank score, then we're fine. Otherwise, it will crash the app.

Collaborator

RyanTG commented Feb 1, 2017

Woohoo! Resolved this error: #136 (comment)

So, java.lang.NumberFormatException: Invalid long: "null" was occurring when loading Portland because the region contained a few - scores. Like, scores with no value. I think these were entered by @scottwainstock recently.

Example: Marie's Lounge's Dirty Harry: by Unknown on Sat, 28 Jan 2017 00:54:08 +0000

Even though it says Unknown, sswtest was adding scores to the same machine around this same time (testing the quintillion point score). So these blank scores seem to be a result of your testing.

But now that's fixed, right? I think people won't be able to enter blank scores. When I enter a blank score in the Android app, it says "Thanks for updating that machine." but nothing is added (note, it should probably give an error, AND valid scores should probably say "Thanks for entering that score." But that's another issue...)

Anyway, as long as no one can ever enter a blank score, then we're fine. Otherwise, it will crash the app.

@RyanTG

This comment has been minimized.

Show comment
Hide comment
@RyanTG

RyanTG Feb 2, 2017

Collaborator

Regarding the TransactionTooLargeException, can that be "resolved" by switching to sdk 23 and target 23? Like, would N devices be ok then?

Another hack would be to remove onSaveInstanceState in places where it won't totally suck to remove it. But that's probably a bad idea.

this thread goes on for a while, with various ideas https://code.google.com/p/android/issues/detail?id=212316

https://medium.com/@andrei.rosca/android-7-transactiontoolargeexception-a-workaround-ffb60fd18bef#.fni9yojah

http://stackoverflow.com/a/40872009

http://stackoverflow.com/a/39747117

Collaborator

RyanTG commented Feb 2, 2017

Regarding the TransactionTooLargeException, can that be "resolved" by switching to sdk 23 and target 23? Like, would N devices be ok then?

Another hack would be to remove onSaveInstanceState in places where it won't totally suck to remove it. But that's probably a bad idea.

this thread goes on for a while, with various ideas https://code.google.com/p/android/issues/detail?id=212316

https://medium.com/@andrei.rosca/android-7-transactiontoolargeexception-a-workaround-ffb60fd18bef#.fni9yojah

http://stackoverflow.com/a/40872009

http://stackoverflow.com/a/39747117

@RyanTG

This comment has been minimized.

Show comment
Hide comment
@RyanTG

RyanTG Feb 2, 2017

Collaborator

I tested it. I changed to sdk 23, and it's not crashing when using a 25 device. The log still shows an error (pasted below), but it doesn't cause the app to crash. In my initial testing on 23 and 25 devices, the only issue is on the region select screen. It's not showing the little header that says, "Alphabetical | Closest" or whatever it says. That part is missing. I'll investigate.

E/JavaBinder: !!! FAILED BINDER TRANSACTION !!! (parcel size = 676016)
E/ActivityThread: App sent too much data in instance state, so it was ignored
android.os.TransactionTooLargeException: data parcel size 676016 bytes
at android.os.BinderProxy.transactNative(Native Method)
at android.os.BinderProxy.transact(Binder.java:615)
at android.app.ActivityManagerProxy.activityStopped(ActivityManagerNative.java:3636)
at android.app.ActivityThread$StopInfo.run(ActivityThread.java:3773)
at android.os.Handler.handleCallback(Handler.java:751)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:154)
at android.app.ActivityThread.main(ActivityThread.java:6119)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:886)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:776)

What say you?

Collaborator

RyanTG commented Feb 2, 2017

I tested it. I changed to sdk 23, and it's not crashing when using a 25 device. The log still shows an error (pasted below), but it doesn't cause the app to crash. In my initial testing on 23 and 25 devices, the only issue is on the region select screen. It's not showing the little header that says, "Alphabetical | Closest" or whatever it says. That part is missing. I'll investigate.

E/JavaBinder: !!! FAILED BINDER TRANSACTION !!! (parcel size = 676016)
E/ActivityThread: App sent too much data in instance state, so it was ignored
android.os.TransactionTooLargeException: data parcel size 676016 bytes
at android.os.BinderProxy.transactNative(Native Method)
at android.os.BinderProxy.transact(Binder.java:615)
at android.app.ActivityManagerProxy.activityStopped(ActivityManagerNative.java:3636)
at android.app.ActivityThread$StopInfo.run(ActivityThread.java:3773)
at android.os.Handler.handleCallback(Handler.java:751)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:154)
at android.app.ActivityThread.main(ActivityThread.java:6119)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:886)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:776)

What say you?

@RyanTG

This comment has been minimized.

Show comment
Hide comment
@RyanTG

RyanTG Feb 2, 2017

Collaborator

Spent a while trying to figure out that region select pager issue. I failed. By all indication (library versions and such) it should work. I think I give up.

I don't know if downgrading is the best idea. But I wish that large transaction error didn't suck so much.

Collaborator

RyanTG commented Feb 2, 2017

Spent a while trying to figure out that region select pager issue. I failed. By all indication (library versions and such) it should work. I think I give up.

I don't know if downgrading is the best idea. But I wish that large transaction error didn't suck so much.

@scottwainstock

This comment has been minimized.

Show comment
Hide comment
@scottwainstock

scottwainstock Feb 4, 2017

Owner

@RyanTG What did we get when we upgraded? If we "downgrade", don't people with the newer SDK just have this issue anyway? Can we FORCE a version of the sdk?

Owner

scottwainstock commented Feb 4, 2017

@RyanTG What did we get when we upgraded? If we "downgrade", don't people with the newer SDK just have this issue anyway? Can we FORCE a version of the sdk?

@RyanTG

This comment has been minimized.

Show comment
Hide comment
@RyanTG

RyanTG Feb 4, 2017

Collaborator
Collaborator

RyanTG commented Feb 4, 2017

@RyanTG

This comment has been minimized.

Show comment
Hide comment
@RyanTG

RyanTG Feb 4, 2017

Collaborator

We are using 22 in the live app, I believe. I think I took advantage of some 23 library during my work, so I'm not sure if we'd want to go back to 22.

When I downgraded to 23 the other day, I had a problem with the region select pager. It's a known issue, but it was resolved in the build I was using, so I didn't understand why I was seeing it. I gave up and reset my branch after that..

Collaborator

RyanTG commented Feb 4, 2017

We are using 22 in the live app, I believe. I think I took advantage of some 23 library during my work, so I'm not sure if we'd want to go back to 22.

When I downgraded to 23 the other day, I had a problem with the region select pager. It's a known issue, but it was resolved in the build I was using, so I didn't understand why I was seeing it. I gave up and reset my branch after that..

@RyanTG

This comment has been minimized.

Show comment
Hide comment
@RyanTG

RyanTG Feb 5, 2017

Collaborator

What say you? Do you want me to make a branch for SDK 23?

Collaborator

RyanTG commented Feb 5, 2017

What say you? Do you want me to make a branch for SDK 23?

@scottwainstock

This comment has been minimized.

Show comment
Hide comment
@scottwainstock

scottwainstock Feb 5, 2017

Owner

@RyanTG Up to you. I haven't had a chance to really dig into fixing any Android stuff since I've been so busy with iOS. So, I have no idea what's the easiest path forward here.

Owner

scottwainstock commented Feb 5, 2017

@RyanTG Up to you. I haven't had a chance to really dig into fixing any Android stuff since I've been so busy with iOS. So, I have no idea what's the easiest path forward here.

@RyanTG

This comment has been minimized.

Show comment
Hide comment
@RyanTG

RyanTG Feb 6, 2017

Collaborator

Looking back at this commit e54c4ad

It looks like that "cardview" library works in api 22. So now the answer to "what did we get from upgrading?" is "I don't know - perhaps nothing." Scratch that, looks like we're using button widgets and stuff from 23.

We could drop to 22.2.1 (https://developer.android.com/topic/libraries/support-library/rev-archive.html#rev22-2-1) and see if all is well. If it is, then let's not upgrade for now.

Collaborator

RyanTG commented Feb 6, 2017

Looking back at this commit e54c4ad

It looks like that "cardview" library works in api 22. So now the answer to "what did we get from upgrading?" is "I don't know - perhaps nothing." Scratch that, looks like we're using button widgets and stuff from 23.

We could drop to 22.2.1 (https://developer.android.com/topic/libraries/support-library/rev-archive.html#rev22-2-1) and see if all is well. If it is, then let's not upgrade for now.

@RyanTG

This comment has been minimized.

Show comment
Hide comment
@RyanTG

RyanTG Feb 6, 2017

Collaborator

I edited the above comment. We are using some 23 things - button widgets.

Collaborator

RyanTG commented Feb 6, 2017

I edited the above comment. We are using some 23 things - button widgets.

@RyanTG

This comment has been minimized.

Show comment
Hide comment
@RyanTG

RyanTG Feb 6, 2017

Collaborator

Possible solution for the pager: http://stackoverflow.com/a/32379051
Basically, insert old v22 pager files into the project.

I think I'll give this a try this evening.

Collaborator

RyanTG commented Feb 6, 2017

Possible solution for the pager: http://stackoverflow.com/a/32379051
Basically, insert old v22 pager files into the project.

I think I'll give this a try this evening.

@RyanTG

This comment has been minimized.

Show comment
Hide comment
@RyanTG

RyanTG Feb 7, 2017

Collaborator

http://stackoverflow.com/a/32379051 did not work. Buncha dumb errors.

Collaborator

RyanTG commented Feb 7, 2017

http://stackoverflow.com/a/32379051 did not work. Buncha dumb errors.

@scottwainstock

This comment has been minimized.

Show comment
Hide comment
@scottwainstock

scottwainstock Feb 12, 2017

Owner

This is the downgrade from 24 to 23.
a882ef6

This is the fix for the region tabs.
2391251

Owner

scottwainstock commented Feb 12, 2017

This is the downgrade from 24 to 23.
a882ef6

This is the fix for the region tabs.
2391251

@scottwainstock

This comment has been minimized.

Show comment
Hide comment
@scottwainstock

scottwainstock Feb 12, 2017

Owner

@RyanTG I just pushed a new build to the developer panel... I think you should get it automatically, but let me know if that doesn't happen. It's version 27.

Owner

scottwainstock commented Feb 12, 2017

@RyanTG I just pushed a new build to the developer panel... I think you should get it automatically, but let me know if that doesn't happen. It's version 27.

@RyanTG

This comment has been minimized.

Show comment
Hide comment
@RyanTG

RyanTG Feb 12, 2017

Collaborator

Sweet!!!

I just swapped my phone's rom the other day and hadn't added back all apps, so I didn't even have this installed (plus, previously I was just using the version that I sent from android studio). I reinstalled it right now. Can't immediately tell if I have version 27. But if not, I'm sure the update will come soon.

Collaborator

RyanTG commented Feb 12, 2017

Sweet!!!

I just swapped my phone's rom the other day and hadn't added back all apps, so I didn't even have this installed (plus, previously I was just using the version that I sent from android studio). I reinstalled it right now. Can't immediately tell if I have version 27. But if not, I'm sure the update will come soon.

@RyanTG

This comment has been minimized.

Show comment
Hide comment
@RyanTG

RyanTG Feb 12, 2017

Collaborator

App last updated on Nov 24. Play store is lagging with the update.

Collaborator

RyanTG commented Feb 12, 2017

App last updated on Nov 24. Play store is lagging with the update.

@RyanTG

This comment has been minimized.

Show comment
Hide comment
@RyanTG

RyanTG Feb 13, 2017

Collaborator

Since my phone doesn't use API 24, I'll verify that it doesn't crash (even though I already know it won't) with Android studio.

Cool that tablayout worked on the region select page. I'm going to try and change the color of the text because right now it's white text and blue background.

Collaborator

RyanTG commented Feb 13, 2017

Since my phone doesn't use API 24, I'll verify that it doesn't crash (even though I already know it won't) with Android studio.

Cool that tablayout worked on the region select page. I'm going to try and change the color of the text because right now it's white text and blue background.

@RyanTG

This comment has been minimized.

Show comment
Hide comment
@RyanTG

RyanTG Feb 13, 2017

Collaborator

updated colors on region select screen: 936261a

API 23 seems good. Closing this. If we find more bugs we can make new issues.

Collaborator

RyanTG commented Feb 13, 2017

updated colors on region select screen: 936261a

API 23 seems good. Closing this. If we find more bugs we can make new issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment