Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location timestamp #385

Closed
RyanTG opened this issue Sep 22, 2015 · 11 comments

Comments

@RyanTG
Copy link
Collaborator

commented Sep 22, 2015

A location timestamp that is updated when: a machine is added or removed; a machine comment is made (could also include when a high score or picture or location description is added).

"Location updated mm/dd/yyyy"

We can put it underneath "Click to enter location description/hours/etc"

@RyanTG

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 22, 2015

Related suggestion: include a "confirm" button that, when clicked, updates the timestamp. I think it could be useful (and it seems easy to add).

Underneath "Location updated mm/dd/yyyy"
"Click to confirm that this location's machine list is up to date"

(that is a bit wordy... I'll think of an edit)

@scottwainstock

This comment has been minimized.

Copy link
Owner

commented Sep 28, 2015

I think I have all the logic in : https://github.com/scottwainstock/pbm/tree/issue_385

... but, would you mind pulling that and putting some styling on it? The "push to confirm" and "last date updated" stuff looks pretty bad.

@RyanTG

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 28, 2015

Yes, will do!

@RyanTG

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 30, 2015

I'll try to commit my changes today. I pulled it and looked at a location this morning, but I didn't see "location updated mm/dd/yyyy." Does that only show up after you've clicked "confirm" once?

@scottwainstock

This comment has been minimized.

Copy link
Owner

commented Sep 30, 2015

Yeah it doesn't update with ajax... so if you click "confirm", you won't see the date until after the page reloads. I can fix that later.

@RyanTG

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 30, 2015

And we already have a "location updated" timestamp, right? Like, that data was there for each location before this issue (I see it when I go to edit a location on the admin page). Can we populate each location with that data?

@scottwainstock

This comment has been minimized.

Copy link
Owner

commented Sep 30, 2015

Not really. That's a rails thing, and I don't think we've plugged into it
very much. It's possible it's only ever set when the object is CREATED (I
think). It might be that it got updated when location.description was
updated, but I'm not sure.

At any rate, it definitely was never updated when machines were
added/remove from a location. So, wouldn't it be misleading if that field
SOMETIMES indicates one thing and SOMETIMES indicates another?

On Wed, Sep 30, 2015 at 10:11 AM, RyanTG notifications@github.com wrote:

And we already have a "location updated" timestamp, right? Like, that data
was there for each location before this issue (I see it when I go to edit a
location on the admin page). Can we populate each location with that data?


Reply to this email directly or view it on GitHub
#385 (comment).

@RyanTG

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 30, 2015

Oh yeah, that would be misleading. I'm in agreement. I've seen jah light.

@scottwainstock

This comment has been minimized.

Copy link
Owner

commented Oct 3, 2015

@RyanTG

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 4, 2015

Should we keep this open for the ajax updating? Right now when you click it, nothing appears to happen.

@scottwainstock

This comment has been minimized.

Copy link
Owner

commented Oct 4, 2015

I'd prefer a new ticket, plz.
On Oct 4, 2015 12:23 PM, "RyanTG" notifications@github.com wrote:

Should we keep this open for the ajax updating? Right now when you click
it, nothing appears to happen.


Reply to this email directly or view it on GitHub
#385 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.