Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against custom blade directives #45

Closed
cschneid opened this issue Jan 7, 2020 · 5 comments · Fixed by #46
Closed

Test against custom blade directives #45

cschneid opened this issue Jan 7, 2020 · 5 comments · Fixed by #46
Assignees
Labels
bug

Comments

@cschneid
Copy link
Member

@cschneid cschneid commented Jan 7, 2020

We had a report of an issue with a custom blade directive.

I did notice that installing your Laravel package broke a custom Blade directive
that we use from the spatie/laravel-permission package.
What’s the best way to troubleshoot this?
For now, I was able to refactor usage of that `@role` directive,
but I’d like to get that fixed and understand why it broke.

I'm asking for any exception or backtrace, but this is worth looking into.

@cschneid

This comment has been minimized.

Copy link
Member Author

@cschneid cschneid commented Jan 7, 2020

@cschneid

This comment has been minimized.

Copy link
Member Author

@cschneid cschneid commented Jan 8, 2020

From the customer:

"No error was caused by the Blade directive, it just rendered the Blade code as text, which broke some conditional logic on the page."

@asgrim asgrim self-assigned this Jan 8, 2020
@asgrim asgrim added the bug label Jan 8, 2020
@asgrim asgrim closed this in #46 Jan 9, 2020
@asgrim

This comment has been minimized.

Copy link
Collaborator

@asgrim asgrim commented Jan 9, 2020

Fixed in 1.2.3 👍

@joelclermont

This comment has been minimized.

Copy link

@joelclermont joelclermont commented Jan 9, 2020

Thank you!!! Such speedy support! I ran into an issue (unrelated, Composer issue) and blogged about it https://joelclermont.com/post/things-to-know-when-updating-a-single-composer-package/

@asgrim

This comment has been minimized.

Copy link
Collaborator

@asgrim asgrim commented Jan 10, 2020

@joelclermont you are most welcome :) Nice post, and good to know! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.