Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not preemptively try to connect if monitoring is disabled #146

Merged
merged 1 commit into from Dec 17, 2019
Merged

Do not preemptively try to connect if monitoring is disabled #146

merged 1 commit into from Dec 17, 2019

Conversation

asgrim
Copy link
Collaborator

@asgrim asgrim commented Dec 17, 2019

Fixes #135

@asgrim asgrim added this to the 2.1.1 milestone Dec 17, 2019
@asgrim asgrim requested a review from cschneid December 17, 2019 12:17
@asgrim asgrim added the bug Something isn't working label Dec 17, 2019
@cschneid cschneid merged commit 0896f86 into master Dec 17, 2019
@asgrim asgrim deleted the only-attempt-to-connect-if-monitoring-enabled branch December 17, 2019 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cschneid cschneid Awaiting requested review from cschneid

Assignees

@cschneid cschneid

Labels
bug Something isn't working
Projects
None yet
Milestone
2.1.1
Development

Successfully merging this pull request may close these issues.

Pre-emptive connect() attempt is called even if monitoring is disabled
2 participants
@asgrim @cschneid