New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable Git Repository Location #91

Merged
merged 2 commits into from Jan 7, 2018

Conversation

Projects
None yet
5 participants
@stephen-lazaro
Copy link
Contributor

stephen-lazaro commented Apr 25, 2017

Probably the simplest way to resolve #54. I didn't end up needing it but maybe someone else would like it. I tested it with the directory ".." and it worked fine, was able to build and push coverage.
Adds SettingKey for git respository location
Makes GitClient initialize to key value else "."

Configurable Git Repository Location
Adds SettingKey for git respository location
Makes GitClient initialized to key value else "."
@randreucetti

This comment has been minimized.

Copy link

randreucetti commented May 17, 2017

Any plans to get this merged ?

@stephen-lazaro

This comment has been minimized.

Copy link
Contributor Author

stephen-lazaro commented Jan 5, 2018

I'm going to close this in three months unless someone prompts. I'm happy to rebase and clean this, but there certainly needs to be some feedback from the project owners beforehand.

@iphydf

This comment has been minimized.

Copy link

iphydf commented Jan 7, 2018

@sksamuel can this be merged and released?

@sksamuel sksamuel merged commit 040db27 into scoverage:master Jan 7, 2018

@sksamuel

This comment has been minimized.

Copy link
Member

sksamuel commented Jan 7, 2018

@stephen-lazaro thanks, I've merged it now.

@gslowikowski gslowikowski added this to the 1.2.3 milestone Apr 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment