Standardise use of CanonicalPath #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Location.scala uses AbstractFile.canonicalPath while ScoverageHtmlWriter.scala uses java.io.File.getAbsolutePath for file paths. This mean that there is a possibility (esp. Windows environment) that creation of reports will fail because the scoverage.coverage.xml created will contain paths with an upper case drive letter while ScoverageHtmlWriter will be using paths with a lower case drive letter.
Member
|
To easily reproduce this issue on Windows with Maven run |
sksamuel
added a commit
that referenced
this pull request
Dec 21, 2014
Standardise use of CanonicalPath
Member
|
Thanks for this. |
Member
|
Tried with Maven, it works. Can you release 1.0.2 with this fix? |
Member
|
Yes will do. |
Member
|
1.0.2 is now released, give it some time to appear on central. |
Member
|
Thanks, add tag for this release, please. @rigoford - scoverage-maven-plugin 1.0.2 is already available. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Location.scala uses AbstractFile.canonicalPath while
ScoverageHtmlWriter.scala uses java.io.File.getAbsolutePath for file
paths. This mean that there is a possibility (esp. Windows environment)
that creation of reports will fail because the scoverage.coverage.xml
created will contain paths with an upper case drive letter while
ScoverageHtmlWriter will be using paths with a lower case drive letter.
Addresses issue #74