GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This reapplies the fix from 8e0304a, which got overwritten at some point.
Reapply the fix from 8e0304a
Download of prebuilt binaries failed: "SSL connect error"!
...Are you kidding? Argh. So much for prebuilt download failures being a thing of the past.
I have no idea why that suddenly stopped working. We could try disabling the TLS verification but that is not really a good idea, especially if it's used to transfer code that gets executed.
Remove unnecessary punctuation
After conversation with Kobrar and DahBlount on Discord, the old line was the correct behavior and the fix should probably be just to clamp it to avoid values of 0 (clamping to between, say, 0.0001 and 1.0 should be safe enough).
I've made that change. @ln-zookeeper, could you test this please?
Yes, the clamping fixes the bug as well.
Old calculation apparently correct, just needs clamping applied.