New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart spring effect after stopping all FF effects #1420

Merged
merged 1 commit into from Aug 2, 2017

Conversation

Projects
None yet
2 participants
@asarium
Member

asarium commented Jul 22, 2017

SDL_HapticStopAll stops all effects, including the spring effect so the
joystick goes limp after one mission (joy_ff_stop_effects gets called at
the end of each mission).

This restarts the spring effect which should fix that issue.

This fixes #1417.

@asarium asarium added the bugfix label Jul 22, 2017

@asarium asarium added this to the Release 3.8 milestone Jul 22, 2017

@The-E

The-E approved these changes Jul 22, 2017

@asarium

This comment has been minimized.

Show comment
Hide comment
@asarium

asarium Jul 24, 2017

Member

I made some changes that might fix this issue properly and give us some more haptic information in the future:

  1. I ported the old code of joy_ff_stop_effects to the SDL platform which should match what the old code did a lot better than the current code.
  2. I added additional logging to determine the features of the used haptic device.
Member

asarium commented Jul 24, 2017

I made some changes that might fix this issue properly and give us some more haptic information in the future:

  1. I ported the old code of joy_ff_stop_effects to the SDL platform which should match what the old code did a lot better than the current code.
  2. I added additional logging to determine the features of the used haptic device.
Restart spring effect after stopping all FF effects
SDL_HapticStopAll stops all effects, including the spring effect so the
joystick goes limp after one mission (joy_ff_stop_effects gets called at
the end of each mission).

This restarts the spring effect which should fix that issue.

This fixes #1417.
@asarium

This comment has been minimized.

Show comment
Hide comment
@asarium

asarium Jul 28, 2017

Member

The newest update fixes the bug properly. This was confirmed by Lykurgos88 in the forum thread.

Member

asarium commented Jul 28, 2017

The newest update fixes the bug properly. This was confirmed by Lykurgos88 in the forum thread.

@The-E The-E merged commit 84fd712 into scp-fs2open:master Aug 2, 2017

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@asarium asarium deleted the asarium:fix/1417 branch Aug 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment