New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix negative coordinates in play-sound-from-x #1463

Merged
merged 1 commit into from Aug 29, 2017

Conversation

Projects
None yet
2 participants
@Goober5000
Contributor

Goober5000 commented Aug 28, 2017

When the OPF_NUMBER and OPF_POSITIVE behaviors were made more robust, it exposed a latent bug in the play-sound sexps. These had OPF_POSITIVE where they should have had OPF_NUMBER. With this fix, sounds can now play from all coordinates, positive or negative.

Goober5000
fix negative coordinates in play-sound-from-x
When the OPF_NUMBER and OPF_POSITIVE behaviors were made more robust, it exposed a latent bug in the play-sound sexps.  These had OPF_POSITIVE where they should have had OPF_NUMBER.  With this fix, sounds can now play from all coordinates, positive or negative.

@asarium asarium merged commit 537ee43 into scp-fs2open:master Aug 29, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Goober5000 Goober5000 deleted the Goober5000:fix_sound_coordinates branch Aug 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment