Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add script-eval-bool #3755

Merged
merged 1 commit into from Oct 30, 2021
Merged

add script-eval-bool #3755

merged 1 commit into from Oct 30, 2021

Conversation

Goober5000
Copy link
Contributor

I'm surprised we didn't have this already.

@Goober5000 Goober5000 added enhancement A new feature or upgrade of an existing feature to add additional functionality. sexps A feature or issue related to SEXPs labels Oct 30, 2021
jg18
jg18 approved these changes Oct 30, 2021
View reviewed changes
Copy link
Member

@jg18 jg18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.

code/parse/sexp.cpp
case OPR_BOOL:
{
auto s = CTEXT(n);
bool r = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While these variable names could be more descriptive, I see they're what's used elsewhere in this function.

@Goober5000 Goober5000 merged commit 8ddf878 into scp-fs2open:master Oct 30, 2021
@Goober5000 Goober5000 deleted the script_eval_bool branch October 30, 2021 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jg18 jg18 jg18 approved these changes

Assignees
No one assigned
Labels
enhancement A new feature or upgrade of an existing feature to add additional functionality. sexps A feature or issue related to SEXPs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Goober5000 @jg18